Skip to content

enable dev cert rotation #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2022
Merged

enable dev cert rotation #1364

merged 1 commit into from
Jul 6, 2022

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Jul 5, 2022

This reverts commit 08973b8, reversing
changes made to 9385abf.

@tkashem
Revert "Merge pull request openshift#1307 from tkashem/revert-cert-ro…
604719e 
…tation"

This reverts commit 08973b8, reversing
changes made to 9385abf.
@tkashem tkashem changed the title Revert "Merge pull request #1307 from tkashem/revert-cert-rotation" enable dev cert rotation Jul 5, 2022
@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial July 5, 2022 14:24
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@tkashem
Copy link
Contributor Author

tkashem commented Jul 5, 2022

/assign @mfojtik @soltysh

@tkashem
Copy link
Contributor Author

tkashem commented Jul 5, 2022

not compatible with openshift next yet

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2022

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 604719e link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 604719e link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Contributor Author

tkashem commented Jul 6, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@openshift-ci openshift-ci bot merged commit 65fc794 into openshift:master Jul 6, 2022
tkashem added a commit to tkashem/cluster-kube-apiserver-operator that referenced this pull request Jul 7, 2022
@tkashem
Revert "Merge pull request openshift#1364 from tkashem/enable-dev-cer…
a9a2b67 
…t-rotation"

This reverts commit 65fc794, reversing
changes made to ff87de9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkashem @soltysh @mfojtik