-
Notifications
You must be signed in to change notification settings - Fork 52
OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit :)
@tiraboschi: This pull request references Jira Issue OCPBUGS-52341, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
CPU PSI pressure as mesured by the Kernel is not able to discriminate self imposed pressure due to CPU throttling on CPU limited containers from pressure caused by resource contention with other neighbors. See: kubernetes/enhancements#5062 In oder to filter out evident false positives, we can introduce a new ActualUtilizationProfile that is consuming CPU PSI pressure value only when the actual average CPU utilization on the node is above a certain threshold (70%), otherwise 0. This is not a systematic solution but a mitigation. Fixes: https://issues.redhat.com/browse/OCPBUGS-52341 Signed-off-by: Simone Tiraboschi <[email protected]>
73c1a60
to
7e4697c
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@ingvagabund: This pull request references Jira Issue OCPBUGS-52341, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@tiraboschi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@tiraboschi: Jira Issue OCPBUGS-52341: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-52341 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…ation OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile
CPU PSI pressure as measured by the Kernel is not able to discriminate self imposed pressure due to CPU throttling on CPU limited containers from pressure caused by resource contention with other neighbors.
See: kubernetes/enhancements#5062
In order to filter out evident false positives, we can introduce a new ActualUtilizationProfile that is consuming CPU PSI pressure value only when the actual average CPU utilization on the node is above a certain threshold (70%), otherwise 0.
This is not a systematic solution but a mitigation.
Fixes: https://issues.redhat.com/browse/OCPBUGS-52341