Skip to content

OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Mar 6, 2025

CPU PSI pressure as measured by the Kernel is not able to discriminate self imposed pressure due to CPU throttling on CPU limited containers from pressure caused by resource contention with other neighbors.

See: kubernetes/enhancements#5062

In order to filter out evident false positives, we can introduce a new ActualUtilizationProfile that is consuming CPU PSI pressure value only when the actual average CPU utilization on the node is above a certain threshold (70%), otherwise 0.
This is not a systematic solution but a mitigation.

Fixes: https://issues.redhat.com/browse/OCPBUGS-52341

@openshift-ci openshift-ci bot requested a review from ingvagabund March 6, 2025 09:01
Copy link
Member

@ingvagabund ingvagabund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit :)

@ingvagabund ingvagabund changed the title Add CPUPSIPressureUtilization ActualUtilizationProfile OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile Mar 6, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 6, 2025
@openshift-ci-robot
Copy link

@tiraboschi: This pull request references Jira Issue OCPBUGS-52341, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CPU PSI pressure as mesured by the Kernel is not able to discriminate self imposed pressure due to CPU throttling on CPU limited containers from pressure caused
by resource contention with other neighbors.
See: kubernetes/enhancements#5062 In oder to filter out evident false positives,
we can introduce a mew ActualUtilizationProfile
that is consuming CPU PSI pressure value only when the actual average CPU utilization on the node is above a certain threshold (70%), otherwise 0.
This is not a systematic solution but a mitigation.

Fixes: https://issues.redhat.com/browse/OCPBUGS-52341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2025
CPU PSI pressure as mesured by the Kernel is not able to
discriminate self imposed pressure due to CPU throttling
on CPU limited containers from pressure caused
by resource contention with other neighbors.
See: kubernetes/enhancements#5062
In oder to filter out evident false positives,
we can introduce a new ActualUtilizationProfile
that is consuming CPU PSI pressure value only when the
actual average CPU utilization on the node is above a certain
threshold (70%), otherwise 0.
This is not a systematic solution but a mitigation.

Fixes: https://issues.redhat.com/browse/OCPBUGS-52341

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi tiraboschi force-pushed the CPUPSIPressureUtilization branch from 73c1a60 to 7e4697c Compare March 6, 2025 09:21
@ingvagabund
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@ingvagabund
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 6, 2025
@openshift-ci-robot
Copy link

@ingvagabund: This pull request references Jira Issue OCPBUGS-52341, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kasturinarra

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2025
@openshift-ci openshift-ci bot requested a review from kasturinarra March 6, 2025 09:24
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

@tiraboschi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e39b45f into openshift:master Mar 6, 2025
6 checks passed
@openshift-ci-robot
Copy link

@tiraboschi: Jira Issue OCPBUGS-52341: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52341 has been moved to the MODIFIED state.

In response to this:

CPU PSI pressure as measured by the Kernel is not able to discriminate self imposed pressure due to CPU throttling on CPU limited containers from pressure caused by resource contention with other neighbors.

See: kubernetes/enhancements#5062

In order to filter out evident false positives, we can introduce a new ActualUtilizationProfile that is consuming CPU PSI pressure value only when the actual average CPU utilization on the node is above a certain threshold (70%), otherwise 0.
This is not a systematic solution but a mitigation.

Fixes: https://issues.redhat.com/browse/OCPBUGS-52341

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tiraboschi pushed a commit to tiraboschi/cluster-kube-descheduler-operator that referenced this pull request Mar 7, 2025
…ation

OCPBUGS-52341: Add CPUPSIPressureUtilization ActualUtilizationProfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants