Skip to content

LOG-1012 Clarify meaning of Ready and Degraded conditions. #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

LOG-1012 Clarify meaning of Ready and Degraded conditions. #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions pkg/apis/logging/v1/conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,29 @@ func NewCondition(t status.ConditionType, s corev1.ConditionStatus, r status.Con
}

const (
// Ready object is providing service. All objects support this condition type.
// Ready indicates the service is ready.
//
// Ready=True means the operands are running and providing some service.
// See the Degraded condition to distinguish full service from partial service.
//
// Ready=False means the operands cannot provide any service, and
// the operator cannot recover without some external change. Either
// the spec is invalid, or there is some environmental problem that is
// outside of the the operator's control.
//
// Ready=Unknown means the operator is in transition.
//
ConditionReady status.ConditionType = "Ready"
// Degraded object can provide some service, but not everything requested in the spec.

// Degraded indicates partial service is available.
//
// Degraded=True means the operands can fulfill some of the `spec`, but not all,
// even when Ready=True.
//
// Degraded=False with Ready=True means the operands are providing full service.
//
// Degraded=Unknown means the operator is in transition.
//
ConditionDegraded status.ConditionType = "Degraded"
)

Expand Down