LOG-2117 Remove deprecated Ginkgo custom reporters #1292
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Why not migrate to v2 and use the built in junit reports so we can see failures in CI https://onsi.github.io/ginkgo/MIGRATING_TO_V2 |
|
@alanconway one of the ideas for the reporters is the results appear in the CI properly instead of having to review the log. I don't think we ever had it working properly. We should consider upgrading to v2 and adding the reporters back in. |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@alanconway: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
LOG-2117 Remove deprecated Ginkgo custom reporters
/cc @jcantril