Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1829723: Update and pin jsonnet dependencies for release 4.7 #1018

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Bug 1829723: Update and pin jsonnet dependencies for release 4.7 #1018

merged 4 commits into from
Dec 11, 2020

Conversation

dgrisonnet
Copy link
Member

@dgrisonnet dgrisonnet commented Dec 11, 2020 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@dgrisonnet
Copy link
Member Author

I still need to bump the version of grafana in upstream kube-prometheus to 7.3.5 and bring it downstream before proceeding with this PR.

@dgrisonnet dgrisonnet changed the title WIP: Update and pin jsonnet dependencies for release 4.7 WIP: Bug 1829723: Update and pin jsonnet dependencies for release 4.7 Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: This pull request references Bugzilla bug 1829723, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1829723: Update and pin jsonnet dependencies for release 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 11, 2020
@dgrisonnet
jsonnet: update jsonnet dependencies
225f510 
Update jsonnet dependencies and pin kube-prometheus version to
release-0.7 for the OpenShift 4.7 feature freeze.

* kube-thanos: release-0.17
* thanos-mixins: release-0.17
* kube-prometheus: release-0.7

Signed-off-by: Damien Grisonnet <[email protected]>
@dgrisonnet
jsonnet/thanos-querier: fix after kube-thanos 1.16
f3d93bd 
kube-thanos v1.16 introduced the following breaking change:
- Expose components via functions with params merged with defaults

Signed-off-by: Damien Grisonnet <[email protected]>
simonpasquier
simonpasquier reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@dgrisonnet
assets,manifests: regenerate
31873e0 
Signed-off-by: Damien Grisonnet <[email protected]>
@dgrisonnet
CHANGELOG.md: update changelog
2c8e805 
Signed-off-by: Damien Grisonnet <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: This pull request references Bugzilla bug 1829723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

WIP: Bug 1829723: Update and pin jsonnet dependencies for release 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet changed the title WIP: Bug 1829723: Update and pin jsonnet dependencies for release 4.7 Bug 1829723: Update and pin jsonnet dependencies for release 4.7 Dec 11, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2020
simonpasquier
simonpasquier reviewed Dec 11, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dgrisonnet,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgrisonnet
Copy link
Member Author

/test e2e-agnostic-operator

@dgrisonnet
Copy link
Member Author

/retest

1 similar comment
@dgrisonnet
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 314353f into openshift:master Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@dgrisonnet: All pull requests linked via external trackers have merged:

Bugzilla bug 1829723 has been moved to the MODIFIED state.

In response to this:

Bug 1829723: Update and pin jsonnet dependencies for release 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet deleted the pin-release-4.7 branch December 14, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgrisonnet @openshift-ci-robot @simonpasquier @openshift-merge-robot