-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1997034: jsonnet: Sync with kube-prometheus #1291
Conversation
/lgtm |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, PhilipGough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that it brings back the kube-apiserver-burnrate.rules
alert group which is managed by the kube-apiserver operator.
Right, I missed it during the review. Upstream changed group names and split those into multiple ones to improve performance a bit and allow splitting evaluation across cortex fleet. Fixed in #1292 |
/bugzilla refresh |
@philipgough: Bugzilla bug 1997034 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@philipgough: Bugzilla bug 1997034 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pulls in prometheus-operator/kube-prometheus#1250 and in doing so drops high cardinality and non required metrics that are scrapped from cAdvisor.
Testing on a nightly cluster this decreases the metric count for cAdvisor by ~12k