Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1997034: jsonnet: Sync with kube-prometheus #1291

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented Jul 20, 2021

This pulls in prometheus-operator/kube-prometheus#1250 and in doing so drops high cardinality and non required metrics that are scrapped from cAdvisor.

Testing on a nightly cluster this decreases the metric count for cAdvisor by ~12k

  • I added CHANGELOG entry for this change.

@openshift-ci openshift-ci bot requested review from fpetkovski and sthaha July 20, 2021 12:43
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@paulfantom
Copy link
Contributor

/lgtm
/hold
putting on hold to allow setting correct PR description :) @philipgough feel free to unhold when ready.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 20, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2021
@philipgough
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@paulfantom
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, PhilipGough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PhilipGough,paulfantom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c595bc9 into openshift:master Jul 20, 2021
@philipgough philipgough deleted the MON-1741 branch July 21, 2021 08:07
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it brings back the kube-apiserver-burnrate.rules alert group which is managed by the kube-apiserver operator.

@paulfantom
Copy link
Contributor

Right, I missed it during the review. Upstream changed group names and split those into multiple ones to improve performance a bit and allow splitting evaluation across cortex fleet.

Fixed in #1292

@philipgough philipgough changed the title jsonnet: Sync with kube-prometheus Bug 1997034: jsonnet: Sync with kube-prometheus Aug 25, 2021
@philipgough
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@philipgough: Bugzilla bug 1997034 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1997034: jsonnet: Sync with kube-prometheus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@philipgough: Bugzilla bug 1997034 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants