Bug 2015386: jsonnet: Add PodDisruptionBudget to KSM metric allow list

[philipgough]

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci]

@philipgough: This pull request references Bugzilla bug 2015386, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2015386: jsonnet: Add PodDisruptionBudget to KSM metric allow list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[philipgough]

/bugzilla refresh

[openshift-ci]

@philipgough: This pull request references Bugzilla bug 2015386, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[philipgough]

/skip

[philipgough]

/hold

[arajkumar]

/lgtm

[juzhao]

there are 5 poddisruptionbudget related metrics

# token=`oc sa get-token prometheus-k8s -n openshift-monitoring`
# oc -n openshift-monitoring exec -c prometheus prometheus-k8s-0 -- curl -k -H "Authorization: Bearer $token" 'https://prometheus-k8s.openshift-monitoring.svc:9091/api/v1/label/__name__/values' | jq | grep poddisruptionbudget
    "kube_poddisruptionbudget_status_current_healthy",
    "kube_poddisruptionbudget_status_desired_healthy",
    "kube_poddisruptionbudget_status_expected_pods",
    "kube_poddisruptionbudget_status_observed_generation",
    "kube_poddisruptionbudget_status_pod_disruptions_allowed",

checked the metrics with the fix, as per https://bugzilla.redhat.com/show_bug.cgi?id=2015386#c2, there is not "kube_poddisruptionbudget_labels" and "kube_poddisruptionbudget_annotations" metrics now, we still need to fix in kube-state-metrics upstream

[arajkumar]

@juzhao , looks like the upstream KSM don't have implementation for poddisruptionbudget. let me fix it in the upstream. Thank you.

[arajkumar]

/hold

[philipgough]

/hold cancel

[philipgough]

We can merge this, but it will have no effect until kubernetes/kube-state-metrics#1623 is pulled in by CMO.

[philipgough]

/retest

[philipgough]

/retest

[philipgough]

/skip

[philipgough]

/retest

[raptorsun]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar, PhilipGough, raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [PhilipGough,arajkumar,raptorsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@philipgough: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-single-node	1d3ad20	link	false	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@philipgough: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#1439

Bugzilla bug 2015386 has been moved to the MODIFIED state.

In response to this:

Bug 2015386: jsonnet: Add PodDisruptionBudget to KSM metric allow list

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.