Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-704: add NLB usage metrics for network edge #1509

Merged
merged 1 commit into from
Dec 17, 2021
Merged

NE-704: add NLB usage metrics for network edge #1509

merged 1 commit into from
Dec 17, 2021

Conversation

tjungblu
Copy link
Contributor

@tjungblu tjungblu commented Dec 8, 2021 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

exposing the metric from #1509

@tjungblu tjungblu mentioned this pull request Dec 8, 2021
Merged
@openshift-ci openshift-ci bot requested review from jan--f and philipgough December 8, 2021 11:57
@tjungblu
Copy link
Contributor Author

tjungblu commented Dec 8, 2021

/hold
until we merge the other PR :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021
@tjungblu
Copy link
Contributor Author

tjungblu commented Dec 8, 2021

/test e2e-agnostic-upgrade

@tjungblu
Copy link
Contributor Author

tjungblu commented Dec 8, 2021

/retest-required

simonpasquier
simonpasquier reviewed Dec 8, 2021
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at openshift/cluster-ingress-operator#675 the metric has a name label. What could be the cardinality of that label?

@tjungblu
Copy link
Contributor Author

tjungblu commented Dec 9, 2021 •
edited
Loading

@simonpasquier yeah good catch, I don't think that would even be necessary. Let me patch that out of the metric.

edit: actually we just need the sum over all names - so let me update this PR in here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021 •
edited
Loading

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 7d2427b link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan--f
Copy link
Contributor

jan--f commented Dec 14, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2021
@tjungblu
Copy link
Contributor Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 16, 2021
@tjungblu
Copy link
Contributor Author

/retest

@jan--f
Copy link
Contributor

jan--f commented Dec 16, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@tjungblu
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@simonpasquier
Copy link
Contributor

/retest

@simonpasquier
Copy link
Contributor

/skip

@simonpasquier
Copy link
Contributor

/lgtm

/label px-approved
/label qe-approved
/label docs-approved

PX, docs and QE have alreay approved in https://issues.redhat.com/browse/NE-704. Given that it's only adding 1 series per cluster, I expect that @smarterclayton is ok with it so I'm not holding the PR.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Dec 17, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/skip

@openshift-merge-robot openshift-merge-robot merged commit 75ae703 into openshift:master Dec 17, 2021
@tjungblu tjungblu deleted the NE-704 branch December 17, 2021 10:20
dgrisonnet pushed a commit to dgrisonnet/cluster-monitoring-operator that referenced this pull request Sep 5, 2023
@tjungblu @dgrisonnet
add NLB usage metrics for network edge (openshift#1509)
06e71f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@jan--f jan--f Awaiting requested review from jan--f

@philipgough philipgough Awaiting requested review from philipgough

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjungblu @jan--f @simonpasquier @openshift-merge-robot