MON-2207: Expose Authorization settings for remote write in the CMO configuration #1598

JoaoBraveCoding · 2022-03-18T17:22:35Z

Problem: Although the prometheus-operator already supports RemoteWriteSpec.Authorization, the CMO did not support this configuration.

Solution: Allow CMO to pass the RemoteWriteSpec.Authorization from the ConfigMap to the Prometheus CRD

Issues: https://issues.redhat.com/browse/MON-2207

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

JoaoBraveCoding · 2022-03-18T19:39:24Z

/test e2e-agnostic-upgrade

JoaoBraveCoding · 2022-03-21T07:41:25Z

/test e2e-agnostic-upgrade

JoaoBraveCoding · 2022-03-21T10:24:02Z

/test e2e-agnostic-upgrade

pkg/manifests/manifests_test.go

JoaoBraveCoding · 2022-03-22T07:10:19Z

/retest

JoaoBraveCoding · 2022-03-22T14:11:58Z

/retest

pkg/manifests/manifests_test.go

JoaoBraveCoding · 2022-03-23T07:32:41Z

/retest

pkg/manifests/manifests_test.go

JoaoBraveCoding · 2022-03-24T08:56:27Z

/retest-required

simonpasquier · 2022-03-24T10:08:43Z

/skip
/lgtm

openshift-bot · 2022-03-24T10:34:46Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-24T13:58:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

JoaoBraveCoding · 2022-03-24T14:54:59Z

Ping @sferich888 for px approval.
Ping @juzhao for qe approval.

openshift-bot · 2022-03-24T15:22:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-24T20:25:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-25T02:36:50Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-25T03:54:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

juzhao · 2022-03-25T05:54:23Z

@lihongyan1 please help to review

JoaoBraveCoding · 2022-03-25T07:52:58Z

/retest-required

openshift-bot · 2022-03-25T10:04:48Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-25T13:16:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

JoaoBraveCoding · 2022-04-05T17:23:05Z

Ping @Senthamilarasu-STA for px approval.

JoaoBraveCoding · 2022-04-06T07:33:16Z

/skip

lihongyan1 · 2022-04-06T07:38:48Z

/label qe-approved

Senthamilarasu-STA · 2022-04-08T05:16:19Z

/label px-approved

test/e2e/prometheus_test.go

Test now fails if the number of function and remoteWrite targets differ Test now reports failed assersions with expected/got error message

jan--f · 2022-04-08T15:12:39Z

test/e2e/prometheus_test.go

@@ -228,7 +228,7 @@ func TestPrometheusRemoteWrite(t *testing.T) {
    tlsConfig:
      ca:
        secret:
-          name: %[2]s
+          name:%[2]s


One last nit :) This change seems unintended and unrelated?

No, that one actually is an improvement. When I was playing around with the tests I noticed that the ConfigMap was not properly formatted when I printed it with -o yaml with "\t" and "\n" showing and it was because of this space.

JoaoBraveCoding · 2022-04-11T09:29:15Z

/retest

JoaoBraveCoding · 2022-04-11T13:07:28Z

/retest-required

JoaoBraveCoding · 2022-04-12T07:00:39Z

/retest-required

jan--f · 2022-04-12T10:10:51Z

/lgtm

openshift-ci · 2022-04-12T10:11:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, JoaoBraveCoding, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoaoBraveCoding,jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-04-12T12:15:29Z

@JoaoBraveCoding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from simonpasquier and slashpai March 18, 2022 17:23

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022

JoaoBraveCoding force-pushed the mon-2207 branch from 08ea476 to 3be3391 Compare March 18, 2022 17:27

simonpasquier reviewed Mar 21, 2022

View reviewed changes

pkg/manifests/manifests_test.go Outdated Show resolved Hide resolved

JoaoBraveCoding force-pushed the mon-2207 branch from 95182d9 to a110124 Compare March 22, 2022 08:20

simonpasquier reviewed Mar 22, 2022

View reviewed changes

pkg/manifests/manifests_test.go Outdated Show resolved Hide resolved

pkg/manifests/manifests_test.go Outdated Show resolved Hide resolved

JoaoBraveCoding force-pushed the mon-2207 branch from e5d9b08 to b22afbd Compare March 23, 2022 09:48

simonpasquier reviewed Mar 23, 2022

View reviewed changes

pkg/manifests/manifests_test.go Outdated Show resolved Hide resolved

pkg/manifests/manifests_test.go Outdated Show resolved Hide resolved

openshift-ci bot assigned simonpasquier Mar 24, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 6, 2022

JoaoBraveCoding force-pushed the mon-2207 branch from 88b9d1d to 62ea862 Compare April 7, 2022 15:25

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 8, 2022

jan--f reviewed Apr 8, 2022

View reviewed changes

test/e2e/prometheus_test.go Outdated Show resolved Hide resolved

JoaoBraveCoding force-pushed the mon-2207 branch from 62ea862 to d4998c8 Compare April 8, 2022 09:42

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022

JoaoBraveCoding added 6 commits April 8, 2022 14:16

Added Authorization field to RemoteWriteSpec

ab7a1d1

Added test TestRemoteWriteAuthorizationConfig

6332d55

Added line to changelog

eddd2bf

Refactored TestRemoteWriteAuthorizationConfig test

c1af060

Refactored test TestRemoteWriteAuthorizationConfig

e46cf6f

Test now fails if the number of function and remoteWrite targets differ Test now reports failed assersions with expected/got error message

Implemented merge requests suggestions

4b419ad

JoaoBraveCoding force-pushed the mon-2207 branch from d4998c8 to fcf55a3 Compare April 8, 2022 13:32

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022

jan--f reviewed Apr 8, 2022

View reviewed changes

Replaced Authorization with SafeAuthorization

a6b416a

JoaoBraveCoding force-pushed the mon-2207 branch from fcf55a3 to a6b416a Compare April 12, 2022 10:07

openshift-ci bot assigned jan--f Apr 12, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022

openshift-merge-robot merged commit 2c494f4 into openshift:master Apr 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MON-2207: Expose Authorization settings for remote write in the CMO configuration #1598

MON-2207: Expose Authorization settings for remote write in the CMO configuration #1598

JoaoBraveCoding commented Mar 18, 2022 •

edited

Loading

JoaoBraveCoding commented Mar 18, 2022

JoaoBraveCoding commented Mar 21, 2022

JoaoBraveCoding commented Mar 21, 2022

JoaoBraveCoding commented Mar 22, 2022

JoaoBraveCoding commented Mar 22, 2022

JoaoBraveCoding commented Mar 23, 2022

JoaoBraveCoding commented Mar 24, 2022

simonpasquier commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

JoaoBraveCoding commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

juzhao commented Mar 25, 2022

JoaoBraveCoding commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

JoaoBraveCoding commented Apr 5, 2022

JoaoBraveCoding commented Apr 6, 2022

lihongyan1 commented Apr 6, 2022

Senthamilarasu-STA commented Apr 8, 2022

jan--f Apr 8, 2022

JoaoBraveCoding Apr 8, 2022

JoaoBraveCoding commented Apr 11, 2022

JoaoBraveCoding commented Apr 11, 2022

JoaoBraveCoding commented Apr 12, 2022

jan--f commented Apr 12, 2022

openshift-ci bot commented Apr 12, 2022

openshift-ci bot commented Apr 12, 2022

MON-2207: Expose Authorization settings for remote write in the CMO configuration #1598

MON-2207: Expose Authorization settings for remote write in the CMO configuration #1598

Conversation

JoaoBraveCoding commented Mar 18, 2022 • edited Loading

JoaoBraveCoding commented Mar 18, 2022

JoaoBraveCoding commented Mar 21, 2022

JoaoBraveCoding commented Mar 21, 2022

JoaoBraveCoding commented Mar 22, 2022

JoaoBraveCoding commented Mar 22, 2022

JoaoBraveCoding commented Mar 23, 2022

JoaoBraveCoding commented Mar 24, 2022

simonpasquier commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

JoaoBraveCoding commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 24, 2022

openshift-bot commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

juzhao commented Mar 25, 2022

JoaoBraveCoding commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

openshift-bot commented Mar 25, 2022

JoaoBraveCoding commented Apr 5, 2022

JoaoBraveCoding commented Apr 6, 2022

lihongyan1 commented Apr 6, 2022

Senthamilarasu-STA commented Apr 8, 2022

jan--f Apr 8, 2022

Choose a reason for hiding this comment

JoaoBraveCoding Apr 8, 2022

Choose a reason for hiding this comment

JoaoBraveCoding commented Apr 11, 2022

JoaoBraveCoding commented Apr 11, 2022

JoaoBraveCoding commented Apr 12, 2022

jan--f commented Apr 12, 2022

openshift-ci bot commented Apr 12, 2022

openshift-ci bot commented Apr 12, 2022

JoaoBraveCoding commented Mar 18, 2022 •

edited

Loading