MON-2206: Adds sigv4 settings for remote write #1638
Conversation
openshift-ci
bot
added
the
approved
JoaoBraveCoding
force-pushed
the
mon-2206
branch
from
d384559 to
3b0d106
Compare
|
Ping @Senthamilarasu-STA for px approval. |
JoaoBraveCoding
changed the title
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
Issue https://issues.redhat.com/browse/MON-2206 Problem: Prometheus and Prometheus operator already support sigv4 authentication for remote write. This should be possible to configure the same in the CMO configuration Solution: Add to the RemoteWriteSpec struct the Sigv4 field so users can specify Sigv4 configuration in the CMO ConfigMap, pass this field to the Prometheus CRD
JoaoBraveCoding
force-pushed
the
mon-2206
branch
from
3b0d106 to
9587e29
Compare
| name: aws-credentials | ||
| key: secret | ||
| profile: "SomeProfile" | ||
| roleArn: "SomeRoleArn" |
There was a problem hiding this comment.
FYI
RoleArn has minimum filed size of 20, otherwise, would see error in prometheus-k8s pod logs
ts=2022-04-14T11:45:44.525Z caller=dedupe.go:112 component=remote level=warn remote_name=a42715 url=https://authorization.remotewrite.com/api/write msg="Failed to send batch, retrying" err="Post \"https://authorization.remotewrite.com/api/write\": failed to sign request: InvalidParameter: 1 validation error(s) found.\n- minimum field size of 20, AssumeRoleInput.RoleArn.\n"
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/lgtm |
|
/assign @Senthamilarasu-STA |
|
@simonpasquier: GitHub didn't allow me to assign the following users: Senthamilarasu-STA. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@JoaoBraveCoding: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Issue https://issues.redhat.com/browse/MON-2206
Problem: Prometheus and Prometheus operator already support sigv4 authentication for
remote write. This should be possible to configure the same in the CMO configuration
Solution: Add to the RemoteWriteSpec struct the Sigv4 field so users can
specify Sigv4 configuration in the CMO ConfigMap, pass this field to the
Prometheus CRD