Skip to content

OCPBUGS-2729: Node Exporter ignore virtual network device 'enP.*'. #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2022
Merged

OCPBUGS-2729: Node Exporter ignore virtual network device 'enP.*'. #1843

merged 1 commit into from
Dec 8, 2022

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Dec 7, 2022 •
edited
Loading

Network interfaces named "enP.*" are virtual network interfaces on Azure cluster. We will ignore them in Node Exporter.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@raptorsun raptorsun force-pushed the bugfix/OCPBUGS-2729 branch from cb6fdae to 6560b90 Compare December 7, 2022 17:20
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2022
@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-2729, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Network interfaces named "enP.*" are virtual network interfaces on Azure cluster. We will ignore them in Node Exporter.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@raptorsun
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-2729, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@raptorsun
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2022
@openshift-ci-robot
Copy link
Contributor

@raptorsun: This pull request references Jira Issue OCPBUGS-2729, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao December 7, 2022 17:22
@raptorsun
Copy link
Contributor Author

/test e2e-agnostic-upgrade

simonpasquier
simonpasquier reviewed Dec 8, 2022
View reviewed changes
jsonnet/main.jsonnet
@@ -181,6 +181,7 @@ local inCluster =
rateInterval: '1m', // adjust the rate interval value to be 4 x the node_exporter's scrape interval (15s).
},
},
ignoredNetworkDevices:: '^(veth.*|[a-f0-9]{15}|enP.*)$',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining the reasons for each exclusion (e.g. like we have in kube-prometheus)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, explanation added :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@raptorsun raptorsun force-pushed the bugfix/OCPBUGS-2729 branch from 6560b90 to 4bd1f34 Compare December 8, 2022 11:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2022

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

simonpasquier
simonpasquier reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

jsonnet/main.jsonnet
@@ -181,6 +181,7 @@ local inCluster =
rateInterval: '1m', // adjust the rate interval value to be 4 x the node_exporter's scrape interval (15s).
},
},
ignoredNetworkDevices:: '^(veth.*|[a-f0-9]{15}|enP.*)$',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [raptorsun,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 10f37b7 into openshift:master Dec 8, 2022
@openshift-ci-robot
Copy link
Contributor

@raptorsun: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2729 has been moved to the MODIFIED state.

In response to this:

Network interfaces named "enP.*" are virtual network interfaces on Azure cluster. We will ignore them in Node Exporter.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raptorsun @openshift-ci-robot @simonpasquier @openshift-merge-robot