Skip to content

OCPBUGS-11434: node-exporter: disable btrfs collector #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Note: This CHANGELOG is only for the monitoring team to track all monitoring related changes. Please see OpenShift release notes for official changes.

## 4.14

- [#1937](https://github.com/openshift/cluster-monitoring-operator/pull/1937) Disables btrfs collector

## 4.13

- [#1785](https://github.com/openshift/cluster-monitoring-operator/pull/1785) Adds support for CollectionProfiles TechPreview
Expand Down
1 change: 1 addition & 0 deletions assets/node-exporter/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ spec:
- --collector.netdev.device-exclude=^(veth.*|[a-f0-9]{15}|enP.*|ovn-k8s-mp[0-9]*|br-ex|br-int|br-ext|br[0-9]*|tun[0-9]*|cali[a-f0-9]*)$
- --collector.cpu.info
- --collector.textfile.directory=/var/node_exporter/textfile
- --no-collector.btrfs
image: quay.io/prometheus/node-exporter:v1.5.0
name: node-exporter
resources:
Expand Down
2 changes: 2 additions & 0 deletions jsonnet/components/node-exporter.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,12 @@ function(params)
// gather that data (especially for bare metal clusters), and
// add flags to collect the node_cpu_info metric + metrics
// from the text file.
// Disable btrfs collector as btrfs is not included in RHEL kernels
args: [a for a in c.args if (a != '--no-collector.hwmon')] +
[
'--collector.cpu.info',
'--collector.textfile.directory=' + textfileDir,
'--no-collector.btrfs',
],
terminationMessagePolicy: 'FallbackToLogsOnError',
volumeMounts+: [{
Expand Down