MON-3163: support VPAs #2078

rexagod · 2023-08-29T01:56:05Z

Note: This requires the latest KSMv2.10 release to work.

Introduce and leverage KSM's CRS featureset and support VPAs using that.

Details

Logs

I1124 10:31:19.440466       1 wrapper.go:98] "Starting kube-state-metrics"
W1124 10:31:19.440711       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1124 10:31:19.440994       1 server.go:192] "Used default resources"
I1124 10:31:19.441025       1 types.go:184] "Using all namespaces"
I1124 10:31:19.441203       1 server.go:225] "Metric allow-denylisting" allowDenyStatus="Excluding the following lists that were on denylist: ^kube_pod_completion_time$, ^kube_pod_status_scheduled$, ^kube_secret_labels$, ^kube_.+_annotations$, ^
W1124 10:31:19.441221       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1124 10:31:19.441812       1 utils.go:70] "Tested communication with server"
I1124 10:31:19.451429       1 utils.go:75] "Run with Kubernetes cluster version" major="1" minor="27" gitVersion="v1.27.6+d548052" gitTreeState="clean" gitCommit="f3ec0ed759cde48849b6e3117c091b7db90c95fa" platform="linux/amd64"
I1124 10:31:19.451470       1 utils.go:76] "Communication with server successful"
I1124 10:31:19.454001       1 server.go:347] "Started metrics server" metricsServerAddress="127.0.0.1:8081"
I1124 10:31:19.454002       1 server.go:336] "Started kube-state-metrics self metrics server" telemetryAddress="127.0.0.1:8082"
I1124 10:31:19.454187       1 server.go:72] levelinfomsgListening onaddress127.0.0.1:8081
I1124 10:31:19.454229       1 server.go:72] levelinfomsgTLS is disabled.http2falseaddress127.0.0.1:8081
I1124 10:31:19.454188       1 server.go:72] levelinfomsgListening onaddress127.0.0.1:8082
I1124 10:31:19.454271       1 server.go:72] levelinfomsgTLS is disabled.http2falseaddress127.0.0.1:8082
I1124 10:31:22.455661       1 config.go:82] "Using custom resource plural" resource="autoscaling.k8s.io_v1_VerticalPodAutoscaler" plural="verticalpodautoscalers"
I1124 10:31:22.455768       1 discovery.go:274] "discovery finished, cache updated"
I1124 10:31:22.455810       1 metrics_handler.go:99] "Autosharding disabled"
I1124 10:31:22.457445       1 custom_resource_metrics.go:79] "Custom resource state added metrics" familyNames=["kube_customresource_kube_verticalpodautoscaler_annotations_info","kube_customresource_kube_verticalpodautoscaler_labels_info","kube_
I1124 10:31:22.568913       1 builder.go:275] "Active resources" activeStoreNames="certificatesigningrequests,configmaps,cronjobs,daemonsets,deployments,endpoints,horizontalpodautoscalers,ingresses,jobs,leases,limitranges,mutatingwebhookconfigur

Query

Generated `ConfigMap`

Name:         kube-state-metrics-custom-resource-state-configmap
Namespace:    openshift-monitoring
Labels:       app.kubernetes.io/managed-by=cluster-monitoring-operator
              app.kubernetes.io/part-of=openshift-monitoring
Annotations:  <none>

Data
====
custom-resource-state-configmap.yaml:
----
"kind": "CustomResourceStateMetrics"
"spec":
  "resources":
  - "groupVersionKind":
      "group": "autoscaling.k8s.io"
      "kind": "VerticalPodAutoscaler"
      "version": "v1"
    "metrics":
    - "commonLabels": null
      "each":
        "info":
          "labelsFromPath":
            "*":
            - "metadata"
            - "annotations"
            "container":
            - "containerName"
          "valueFrom": 1
        "type": "Info"
      "help": "Kubernetes annotations converted to Prometheus labels."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_annotations_info"
    - "commonLabels": null
      "each":
        "info":
          "labelsFromPath":
            "*":
            - "metadata"
            - "labels"
            "container":
            - "containerName"
          "valueFrom": 1
        "type": "Info"
      "help": "Kubernetes labels converted to Prometheus labels."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_labels_info"
    - "commonLabels": null
      "each":
        "stateSet":
          "labelName": "updatemode"
          "list":
          - "Off"
          - "Initial"
          - "Recreate"
          - "Auto"
          "path":
          - "spec"
          - "updatePolicy"
          - "updateMode"
        "type": "StateSet"
      "help": "Update mode of the VerticalPodAutoscaler."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_spec_updatepolicy_updatemode"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "lowerBound"
          - "cpu"
        "type": "Gauge"
      "help": "Minimum cpu resources the container can use before the VerticalPodAutoscaler updater evicts it."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_lowerbound_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "lowerBound"
          - "memory"
        "type": "Gauge"
      "help": "Minimum memory resources the container can use before the VerticalPodAutoscaler updater evicts it."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_lowerbound_memory"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "upperBound"
          - "cpu"
        "type": "Gauge"
      "help": "Maximum cpu resources the container can use before the VerticalPodAutoscaler updater evicts it."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_upperbound_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "upperBound"
          - "memory"
        "type": "Gauge"
      "help": "Maximum memory resources the container can use before the VerticalPodAutoscaler updater evicts it."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_upperbound_memory"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "target"
          - "cpu"
        "type": "Gauge"
      "help": "Target cpu resources the VerticalPodAutoscaler recommends for the container."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_target_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "target"
          - "memory"
        "type": "Gauge"
      "help": "Target memory resources the VerticalPodAutoscaler recommends for the container."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_target_memory"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "uncappedTarget"
          - "cpu"
        "type": "Gauge"
      "help": "Target cpu resources the VerticalPodAutoscaler recommends for the container ignoring bounds."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_uncappedtarget_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "status"
          - "recommendation"
          - "containerRecommendations"
          "valueFrom":
          - "uncappedTarget"
          - "memory"
        "type": "Gauge"
      "help": "Target memory resources the VerticalPodAutoscaler recommends for the container ignoring bounds."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_uncappedtarget_memory"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "spec"
          - "resourcePolicy"
          - "containerPolicies"
          "valueFrom":
          - "minAllowed"
          - "cpu"
        "type": "Gauge"
      "help": "Minimum cpu resources the VerticalPodAutoscaler can set for containers matching the name."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "spec"
          - "resourcePolicy"
          - "containerPolicies"
          "valueFrom":
          - "minAllowed"
          - "memory"
        "type": "Gauge"
      "help": "Minimum memory resources the VerticalPodAutoscaler can set for containers matching the name."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed_memory"
    - "commonLabels":
        "resource": "cpu"
        "unit": "cores"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "spec"
          - "resourcePolicy"
          - "containerPolicies"
          "valueFrom":
          - "maxAllowed"
          - "cpu"
        "type": "Gauge"
      "help": "Minimum cpu resources the VerticalPodAutoscaler can set for containers matching the name."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_maxallowed_cpu"
    - "commonLabels":
        "resource": "memory"
        "unit": "bytes"
      "each":
        "gauge":
          "labelsFromPath":
            "container":
            - "containerName"
          "path":
          - "spec"
          - "resourcePolicy"
          - "containerPolicies"
          "valueFrom":
          - "maxAllowed"
          - "memory"
        "type": "Gauge"
      "help": "Minimum memory resources the VerticalPodAutoscaler can set for containers matching the name."
      "labelsFromPath":
        "namespace":
        - "metadata"
        - "namespace"
        "target_api_version":
        - "spec"
        - "targetRef"
        - "apiVersion"
        "target_kind":
        - "spec"
        - "targetRef"
        - "kind"
        "target_name":
        - "spec"
        - "targetRef"
        - "name"
        "verticalpodautoscaler":
        - "metadata"
        - "name"
      "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_maxallowed_memory"

BinaryData
====

Events:  <none>

I added CHANGELOG entry for this change.

openshift-ci-robot · 2023-08-29T02:04:54Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Introduce and leverage KSM's CRS featureset and support VPAs using that.

[PENDING] I added CHANGELOG entry for this change.

~~[ ] No user facing changes, so no entry in CHANGELOG was needed.~~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-08-29T02:04:55Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Introduce and leverage KSM's CRS featureset and support VPAs using that.

[PENDING] I added CHANGELOG entry for this change.

~~[ ] No user facing changes, so no entry in CHANGELOG was needed.~~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-08-29T02:04:56Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2023-08-29T02:05:12Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Introduce and leverage KSM's CRS featureset and support VPAs using that.

[PENDING] I added CHANGELOG entry for this change.

~~[ ] No user facing changes, so no entry in CHANGELOG was needed.~~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-04T14:11:13Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Note: This requires the latest KSMv2.10 release to work.

Introduce and leverage KSM's CRS featureset and support VPAs using that.

[PENDING] I added CHANGELOG entry for this change.

~~[ ] No user facing changes, so no entry in CHANGELOG was needed.~~

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-04T16:14:32Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Note: This requires the latest KSMv2.10 release to work.

Introduce and leverage KSM's CRS featureset and support VPAs using that.

[*] I added CHANGELOG entry for this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-04T16:14:43Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Note: This requires the latest KSMv2.10 release to work.

Introduce and leverage KSM's CRS featureset and support VPAs using that.

I added CHANGELOG entry for this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rexagod · 2023-09-04T16:16:03Z

/jira refresh

openshift-ci-robot · 2023-09-04T16:16:05Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jan--f · 2023-09-13T14:25:08Z

/cc

jan--f

I've done a first pass, things looks good.
I find the new jsonnet file a little hard to follow, but I need to reacquaint myself a bit with jsonnet before I'll come back with something constructive.

jsonnet/components/kube-state-metrics.libsonnet

jan--f · 2023-09-21T13:42:58Z

Proposed some jsonnet changes in rexagod#1

rexagod · 2023-11-21T09:40:03Z

/retest
/jira refresh

openshift-ci-robot · 2023-11-21T09:40:06Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

/retest
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rexagod · 2023-11-21T20:04:21Z

/retest

jan--f · 2024-04-24T13:32:31Z

/lgtm

openshift-ci · 2024-04-24T13:41:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jan--f,rexagod]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jan--f · 2024-04-24T13:55:08Z

@rexagod feel free to unhold unless this still needs review from a VPA team.

rexagod · 2024-04-24T14:52:18Z

@jan--f Just to clarify, do you mean the Node team (Joel)? They were the ones with this request initially.

Or should I ping the autoscaling team to get a review here?

PS. As you know, VPA metrics being introduced here are more of a "re-introduction" since these used to exist within KSM before being deprecated, adhering to the same behavior that they had, so I believe we should be safe to /unhold this either way. But LMK otherwise and I'll ping the teams.

jan--f · 2024-04-24T14:56:55Z

You added a hold a while back in #2078 (comment)

I just didn't want to preempt anything. Feel free to unhold unless you want anyone else's eyes on this.

rexagod · 2024-04-24T15:05:09Z

ACK, I've pinged the autoscaling team to take a look. 🤞🏼

rexagod · 2024-04-24T15:07:09Z

/test e2e-aws-ovn-single-node

We might have to skip this one, since the failures do not indicate any issues with the patch itself.

jan--f · 2024-04-24T15:12:02Z

The single node test is not required...that won't block the merge. Only the hold label blocks this currently.

joelsmith · 2024-04-24T21:23:40Z

LGTM, thanks!

rexagod · 2024-04-25T06:34:04Z

/unhold

Thanks, Joel! Unholding now.

jan--f · 2024-04-25T08:12:16Z

/retest

juzhao · 2024-04-25T08:57:10Z

bug:https://issues.redhat.com/browse/OCPBUGS-32949

jan--f · 2024-04-25T09:08:27Z

/hold
might be worth fixing the bug first

rexagod · 2024-04-25T09:36:11Z

Simon and I went over this here: #2078 (comment), PTAL.

juzhao · 2024-04-25T09:49:24Z

Simon and I went over this here: #2078 (comment), PTAL.

thanks for the explanation, let the kube-state-metrics pod run for a few time, the error only shown once, delete the kube-state-metrics pod, watch for a while, no such errors.

juzhao · 2024-04-25T10:04:01Z

/label qe-approved

openshift-ci-robot · 2024-04-25T10:04:07Z

@rexagod: This pull request references MON-3163 which is a valid jira issue.

In response to this:

Note: This requires the latest KSMv2.10 release to work.

Introduce and leverage KSM's CRS featureset and support VPAs using that.

Details

Logs

I1124 10:31:19.440466       1 wrapper.go:98] "Starting kube-state-metrics"
W1124 10:31:19.440711       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1124 10:31:19.440994       1 server.go:192] "Used default resources"
I1124 10:31:19.441025       1 types.go:184] "Using all namespaces"
I1124 10:31:19.441203       1 server.go:225] "Metric allow-denylisting" allowDenyStatus="Excluding the following lists that were on denylist: ^kube_pod_completion_time$, ^kube_pod_status_scheduled$, ^kube_secret_labels$, ^kube_.+_annotations$, ^
W1124 10:31:19.441221       1 client_config.go:618] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I1124 10:31:19.441812       1 utils.go:70] "Tested communication with server"
I1124 10:31:19.451429       1 utils.go:75] "Run with Kubernetes cluster version" major="1" minor="27" gitVersion="v1.27.6+d548052" gitTreeState="clean" gitCommit="f3ec0ed759cde48849b6e3117c091b7db90c95fa" platform="linux/amd64"
I1124 10:31:19.451470       1 utils.go:76] "Communication with server successful"
I1124 10:31:19.454001       1 server.go:347] "Started metrics server" metricsServerAddress="127.0.0.1:8081"
I1124 10:31:19.454002       1 server.go:336] "Started kube-state-metrics self metrics server" telemetryAddress="127.0.0.1:8082"
I1124 10:31:19.454187       1 server.go:72] levelinfomsgListening onaddress127.0.0.1:8081
I1124 10:31:19.454229       1 server.go:72] levelinfomsgTLS is disabled.http2falseaddress127.0.0.1:8081
I1124 10:31:19.454188       1 server.go:72] levelinfomsgListening onaddress127.0.0.1:8082
I1124 10:31:19.454271       1 server.go:72] levelinfomsgTLS is disabled.http2falseaddress127.0.0.1:8082
I1124 10:31:22.455661       1 config.go:82] "Using custom resource plural" resource="autoscaling.k8s.io_v1_VerticalPodAutoscaler" plural="verticalpodautoscalers"
I1124 10:31:22.455768       1 discovery.go:274] "discovery finished, cache updated"
I1124 10:31:22.455810       1 metrics_handler.go:99] "Autosharding disabled"
I1124 10:31:22.457445       1 custom_resource_metrics.go:79] "Custom resource state added metrics" familyNames=["kube_customresource_kube_verticalpodautoscaler_annotations_info","kube_customresource_kube_verticalpodautoscaler_labels_info","kube_
I1124 10:31:22.568913       1 builder.go:275] "Active resources" activeStoreNames="certificatesigningrequests,configmaps,cronjobs,daemonsets,deployments,endpoints,horizontalpodautoscalers,ingresses,jobs,leases,limitranges,mutatingwebhookconfigur

Query

Generated `ConfigMap`

Name:         kube-state-metrics-custom-resource-state-configmap
Namespace:    openshift-monitoring
Labels:       app.kubernetes.io/managed-by=cluster-monitoring-operator
             app.kubernetes.io/part-of=openshift-monitoring
Annotations:  <none>

Data
====
custom-resource-state-configmap.yaml:
----
"kind": "CustomResourceStateMetrics"
"spec":
 "resources":
 - "groupVersionKind":
     "group": "autoscaling.k8s.io"
     "kind": "VerticalPodAutoscaler"
     "version": "v1"
   "metrics":
   - "commonLabels": null
     "each":
       "info":
         "labelsFromPath":
           "*":
           - "metadata"
           - "annotations"
           "container":
           - "containerName"
         "valueFrom": 1
       "type": "Info"
     "help": "Kubernetes annotations converted to Prometheus labels."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_annotations_info"
   - "commonLabels": null
     "each":
       "info":
         "labelsFromPath":
           "*":
           - "metadata"
           - "labels"
           "container":
           - "containerName"
         "valueFrom": 1
       "type": "Info"
     "help": "Kubernetes labels converted to Prometheus labels."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_labels_info"
   - "commonLabels": null
     "each":
       "stateSet":
         "labelName": "updatemode"
         "list":
         - "Off"
         - "Initial"
         - "Recreate"
         - "Auto"
         "path":
         - "spec"
         - "updatePolicy"
         - "updateMode"
       "type": "StateSet"
     "help": "Update mode of the VerticalPodAutoscaler."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_spec_updatepolicy_updatemode"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "lowerBound"
         - "cpu"
       "type": "Gauge"
     "help": "Minimum cpu resources the container can use before the VerticalPodAutoscaler updater evicts it."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_lowerbound_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "lowerBound"
         - "memory"
       "type": "Gauge"
     "help": "Minimum memory resources the container can use before the VerticalPodAutoscaler updater evicts it."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_lowerbound_memory"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "upperBound"
         - "cpu"
       "type": "Gauge"
     "help": "Maximum cpu resources the container can use before the VerticalPodAutoscaler updater evicts it."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_upperbound_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "upperBound"
         - "memory"
       "type": "Gauge"
     "help": "Maximum memory resources the container can use before the VerticalPodAutoscaler updater evicts it."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_upperbound_memory"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "target"
         - "cpu"
       "type": "Gauge"
     "help": "Target cpu resources the VerticalPodAutoscaler recommends for the container."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_target_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "target"
         - "memory"
       "type": "Gauge"
     "help": "Target memory resources the VerticalPodAutoscaler recommends for the container."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_target_memory"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "uncappedTarget"
         - "cpu"
       "type": "Gauge"
     "help": "Target cpu resources the VerticalPodAutoscaler recommends for the container ignoring bounds."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_uncappedtarget_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "status"
         - "recommendation"
         - "containerRecommendations"
         "valueFrom":
         - "uncappedTarget"
         - "memory"
       "type": "Gauge"
     "help": "Target memory resources the VerticalPodAutoscaler recommends for the container ignoring bounds."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_status_recommendation_containerrecommendations_uncappedtarget_memory"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "spec"
         - "resourcePolicy"
         - "containerPolicies"
         "valueFrom":
         - "minAllowed"
         - "cpu"
       "type": "Gauge"
     "help": "Minimum cpu resources the VerticalPodAutoscaler can set for containers matching the name."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "spec"
         - "resourcePolicy"
         - "containerPolicies"
         "valueFrom":
         - "minAllowed"
         - "memory"
       "type": "Gauge"
     "help": "Minimum memory resources the VerticalPodAutoscaler can set for containers matching the name."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_minallowed_memory"
   - "commonLabels":
       "resource": "cpu"
       "unit": "cores"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "spec"
         - "resourcePolicy"
         - "containerPolicies"
         "valueFrom":
         - "maxAllowed"
         - "cpu"
       "type": "Gauge"
     "help": "Minimum cpu resources the VerticalPodAutoscaler can set for containers matching the name."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_maxallowed_cpu"
   - "commonLabels":
       "resource": "memory"
       "unit": "bytes"
     "each":
       "gauge":
         "labelsFromPath":
           "container":
           - "containerName"
         "path":
         - "spec"
         - "resourcePolicy"
         - "containerPolicies"
         "valueFrom":
         - "maxAllowed"
         - "memory"
       "type": "Gauge"
     "help": "Minimum memory resources the VerticalPodAutoscaler can set for containers matching the name."
     "labelsFromPath":
       "namespace":
       - "metadata"
       - "namespace"
       "target_api_version":
       - "spec"
       - "targetRef"
       - "apiVersion"
       "target_kind":
       - "spec"
       - "targetRef"
       - "kind"
       "target_name":
       - "spec"
       - "targetRef"
       - "name"
       "verticalpodautoscaler":
       - "metadata"
       - "name"
     "name": "kube_verticalpodautoscaler_spec_resourcepolicy_container_policies_maxallowed_memory"

BinaryData
====

Events:  <none>

I added CHANGELOG entry for this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rexagod · 2024-04-25T10:07:56Z

/retest
/hold cancel

rexagod · 2024-04-25T10:20:05Z

/hold

Just to make sure #2078 (comment) looks good to Jan, in which case, feel free to unhold.

jan--f · 2024-04-26T08:04:39Z

Thanks for the details.
/unhold
/retest

openshift-ci · 2024-04-26T10:52:56Z

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-04-26T15:49:17Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-monitoring-operator-container-v4.16.0-202404261114.p0.g77f948e.assembly.stream.el9 for distgit cluster-monitoring-operator.
All builds following this will include this PR.

rexagod changed the title ~~feat: support VPAs~~ MON-3163: support VPAs Aug 29, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 29, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023

rexagod force-pushed the 2858 branch 2 times, most recently from 4120fa0 to a619580 Compare September 4, 2023 14:10

rexagod force-pushed the 2858 branch from a619580 to a27b10a Compare September 4, 2023 16:10

rexagod marked this pull request as ready for review September 4, 2023 16:12

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2023

openshift-ci bot requested review from marioferh and sthaha September 4, 2023 16:13

rexagod force-pushed the 2858 branch from a27b10a to 89eb3cb Compare September 4, 2023 16:14

openshift-ci bot requested a review from jan--f September 13, 2023 14:25

jan--f reviewed Sep 13, 2023

View reviewed changes

jsonnet/components/kube-state-metrics.libsonnet Outdated Show resolved Hide resolved

rexagod requested a review from jan--f October 31, 2023 08:44

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023

rexagod force-pushed the 2858 branch from 84f1c8a to 746c14a Compare November 21, 2023 14:57

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 25, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024

openshift-merge-bot bot merged commit 77f948e into openshift:master Apr 26, 2024
17 checks passed

MON-3163: support VPAs #2078

MON-3163: support VPAs #2078

Conversation

rexagod commented Aug 29, 2023 • edited Loading

Logs

Query

Generated ConfigMap

openshift-ci-robot commented Aug 29, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Aug 29, 2023 • edited by openshift-ci bot Loading

openshift-ci bot commented Aug 29, 2023

openshift-ci-robot commented Aug 29, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Sep 4, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Sep 4, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Sep 4, 2023 • edited by openshift-ci bot Loading

rexagod commented Sep 4, 2023

openshift-ci-robot commented Sep 4, 2023 • edited by openshift-ci bot Loading

jan--f commented Sep 13, 2023

jan--f left a comment

Choose a reason for hiding this comment

jan--f commented Sep 21, 2023

rexagod commented Nov 21, 2023

openshift-ci-robot commented Nov 21, 2023 • edited by openshift-ci bot Loading

rexagod commented Nov 21, 2023

jan--f commented Apr 24, 2024

openshift-ci bot commented Apr 24, 2024

jan--f commented Apr 24, 2024

rexagod commented Apr 24, 2024 • edited Loading

jan--f commented Apr 24, 2024

rexagod commented Apr 24, 2024

rexagod commented Apr 24, 2024

jan--f commented Apr 24, 2024

joelsmith commented Apr 24, 2024

rexagod commented Apr 25, 2024

jan--f commented Apr 25, 2024

juzhao commented Apr 25, 2024

jan--f commented Apr 25, 2024

rexagod commented Apr 25, 2024

juzhao commented Apr 25, 2024

juzhao commented Apr 25, 2024

openshift-ci-robot commented Apr 25, 2024 • edited by openshift-ci bot Loading

Logs

Query

Generated ConfigMap

rexagod commented Apr 25, 2024

rexagod commented Apr 25, 2024

jan--f commented Apr 26, 2024

openshift-ci bot commented Apr 26, 2024

openshift-bot commented Apr 26, 2024

rexagod commented Aug 29, 2023 •

edited

Loading

Generated `ConfigMap`

openshift-ci-robot commented Aug 29, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 29, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 29, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 21, 2023 •

edited by openshift-ci bot

Loading

rexagod commented Apr 24, 2024 •

edited

Loading

openshift-ci-robot commented Apr 25, 2024 •

edited by openshift-ci bot

Loading

Generated `ConfigMap`