Skip to content

Remove deprecated user workload configuration #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Nov 18, 2020

With 4.7 onwards we do not support techPreview configuration, so code that handles that can be removed. Users had one release to migrate, as agreed beforehand. I added a log warning users if they still use that that it will simply not work. We will also mention this in the CHANGELOG as well as in the docs for 4.7, in 4.6 we do not mention the old techPreview configuration anyways.

  • I added CHANGELOG entry for this change.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@lilic lilic force-pushed the remove-old-config branch from 821a698 to d33cca5 Compare November 18, 2020 10:28
@lilic lilic force-pushed the remove-old-config branch from d33cca5 to 8ea7972 Compare November 18, 2020 10:28
@lilic lilic changed the title WIP: Remove deprecated user workload configuration Remove deprecated user workload configuration Nov 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
@lilic
Copy link
Contributor Author

lilic commented Nov 18, 2020

@openshift/openshift-team-monitoring please have a look, thanks!

@lilic
Copy link
Contributor Author

lilic commented Nov 18, 2020

Tested on the cluster launched from this PR and used old tech preview field which nicely resulted in non broken stack and the following in the logs:

I1118 13:24:33.034750 1 tasks.go:46] ran task 3 of 15: Updating Cluster Monitoring Operator
I1118 13:24:34.098157 1 tasks.go:46] ran task 1 of 15: Updating Prometheus Operator
I1118 13:24:34.911699 1 tasks.go:46] ran task 12 of 15: Updating Telemeter client
W1118 13:24:36.345776 1 config.go:431] DEPRECATED: Migrate to new user workload monitoring configuration, this tech preview was removed.

@lilic
Copy link
Contributor Author

lilic commented Nov 18, 2020

/retest

@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fff7ac2 into openshift:master Nov 18, 2020
@lilic lilic deleted the remove-old-config branch November 19, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants