Bug 1897252: Add Thanos query log level #995
Conversation
Due to a recent bug around thanos query, we want to enable log level debug in CI to see any possible hints what is going wrong.
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@lilic: This pull request references Bugzilla bug 1897252, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
cc @openshift/openshift-team-monitoring PTAL, thanks! |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -428,6 +429,8 @@ func (c *Config) IsUserWorkloadEnabled() bool { | |||
| // and depracted from 4.7 onwards. | |||
| // Instead warn user in the logs. | |||
| func (c *UserWorkloadConfig) isEnabled() bool { | |||
| klog.Warning("DEPRECATED: Migrate to new user workload monitoring configuration, this tech preview was removed.") | |||
| if c.Enabled != nil { | |||
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@lilic: This pull request references Bugzilla bug 1897252, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lilic: All pull requests linked via external trackers have merged: Bugzilla bug 1897252 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds the ability to modify verbosity of log level for thanos query. We need this in CI to debug a thanos query bug (linked as a bugzilla), so might be useful for our customers as well.
Also noticed we now always logged the msg about techPreview being DEPRECATED, so now we only shout at users in logs that we have DEPRECATED the techPreview, is they set Enabled field.