Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2090437: Bump CNO to k8s 1.24 #1459

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Bug 2090437: Bump CNO to k8s 1.24 #1459

merged 1 commit into from
Jun 3, 2022

Conversation

msherif1234
Copy link
Contributor

update CNO to kube1.24
Signed-off-by: Mohamed Mahmoud [email protected]

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@msherif1234: This pull request references Bugzilla bug 2090437, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2090437: Bump CNO to k8s 1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from dcbw and tssurya May 25, 2022 18:32
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2022
@msherif1234
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2022

@msherif1234: This pull request references Bugzilla bug 2090437, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from anuragthehatter May 25, 2022 18:46
@msherif1234
Copy link
Contributor Author

/assign @danwinship

@msherif1234
Copy link
Contributor Author

/retest

1 similar comment
@msherif1234
Copy link
Contributor Author

/retest

danwinship
danwinship reviewed May 26, 2022
View reviewed changes
pkg/controller/statusmanager/status_manager_test.go
ObjectMeta: metav1.ObjectMeta{Namespace: "one", Name: "alpha", Generation: 1, ClusterName: "", Labels: sl},
ObjectMeta: metav1.ObjectMeta{Namespace: "one", Name: "alpha", Generation: 1, Labels: sl},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in apimachinery 1.24 says "ClusterName was a legacy field that was always cleared by the system and never used." And we're setting it to "" anyway... so this seems fine, but it makes me wonder why it's even there at all and if this points to a bug/gap in the test cases? It would be good to dig into that a little...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was added by hypershift team but it has no use and it was agreed on removing it
slack thread

@msherif1234 msherif1234 force-pushed the kube_update_1.24 branch 2 times, most recently from bd32599 to 9eef13e Compare May 26, 2022 13:20
@msherif1234 msherif1234 requested a review from danwinship May 26, 2022 13:24
@msherif1234
Bug 2090437: Bump CNO to k8s 1.24
f58b1a9 
Signed-off-by: Mohamed Mahmoud <[email protected]>
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 26, 2022
@msherif1234 msherif1234 mentioned this pull request May 26, 2022
Closed
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD bc1d913 and 8 for PR HEAD f58b1a9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD bc1d913 and 7 for PR HEAD f58b1a9 in total

@dcbw
Copy link
Contributor

dcbw commented Jun 1, 2022

/override ci/prow/e2e-aws-ovn-windows

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Jun 1, 2022

/override ci/prow/e2e-aws-ovn-windows

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/retest-required

1 similar comment
@msherif1234
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD a24c015 and 1 for PR HEAD f58b1a9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a24c015 and 0 for PR HEAD f58b1a9 in total

@msherif1234
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link
Contributor

/hold

Revision f58b1a9 was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@msherif1234
Copy link
Contributor Author

/retest-required

@msherif1234
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@msherif1234
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 84ca9b2 and 8 for PR HEAD f58b1a9 in total

@msherif1234
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 84ca9b2 and 7 for PR HEAD f58b1a9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 84ca9b2 and 6 for PR HEAD f58b1a9 in total

@dcbw
Copy link
Contributor

dcbw commented Jun 3, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6
Failed to pull image \"quay.io/openshift/origin-kube-rbac-proxy:latest\": rpc error: code = Unknown desc = pinging container registry quay.io: Get \"https://quay.io/v2/\": dial tcp [2600:1f18:483:cf01:b459:f0da:7a10:a76e]:443: i/o timeout"

Yet many other images were just fine...

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
Failed to pull image \"quay.io/openshift/origin-kube-rbac-proxy:latest\": rpc error: code = Unknown desc = pinging container registry quay.io: Get \"https://quay.io/v2/\": dial tcp [2600:1f18:483:cf01:b459:f0da:7a10:a76e]:443: i/o timeout"

Yet many other images were just fine...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 90e879f and 5 for PR HEAD f58b1a9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 90e879f and 4 for PR HEAD f58b1a9 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 90e879f and 3 for PR HEAD f58b1a9 in total

@danwinship
Copy link
Contributor

danwinship commented Jun 3, 2022 •
edited by dcbw
Loading

/override ci/prow/e2e-metal-ipi-ovn-ipv6
(problem in another operator)
openshift/insights-operator#635

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
(problem in another operator)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@msherif1234: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn f58b1a9 link false /test e2e-openstack-ovn
ci/prow/e2e-hypershift f58b1a9 link false /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 26c2a62 into openshift:master Jun 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@msherif1234: All pull requests linked via external trackers have merged:

Bugzilla bug 2090437 has been moved to the MODIFIED state.

In response to this:

Bug 2090437: Bump CNO to k8s 1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyrtapz kyrtapz mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msherif1234 @danwinship @openshift-ci-robot @dcbw @openshift-merge-robot