Skip to content

Bug 1710937: delete owner reference from servicebindings #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 11, 2019

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Aug 23, 2019

Allow the Service Catalog apiserver to be cleaned up when removed.

@jmrodri jmrodri requested a review from joelanford August 23, 2019 03:33
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2019
@jmrodri jmrodri requested a review from shawn-hurley August 23, 2019 03:33
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@jmrodri jmrodri added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 23, 2019
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits and continue question addressed.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 27, 2019

  • apiservice is gone
Error from server (NotFound): apiservices.apiregistration.k8s.io "v1beta1.servicecatalog.k8s.io" not found
  • Secret has no owner reference now
[jesusr@transam cluster-svcat-apiserver-operator{bz1710937}]$ oc get secret rhcc-mysql-apb -o yaml
apiVersion: v1
data:
  DB_HOST: bXlzcWwtNjQ2MDk2ZjUtYzkwNy0xMWU5LTlkNmMtMGE1ODBhODEwMDM0
  DB_NAME: ZGV2ZWw=
  DB_PASSWORD: cGFzc3dvcmQ=
  DB_PORT: MzMwNg==
  DB_TYPE: bXlzcWw=
  DB_USER: ZGV2ZWw=
kind: Secret
metadata:
  creationTimestamp: "2019-08-27T20:16:04Z"
  name: rhcc-mysql-apb
  namespace: blogproject2
  resourceVersion: "57760"
  selfLink: /api/v1/namespaces/blogproject2/secrets/rhcc-mysql-apb
  uid: 7f11c502-c907-11e9-9674-0a08a7c6d55e
type: Opaque
  • service catalog namespace is gone as well
[jesusr@transam cluster-svcat-apiserver-operator{bz1710937}]$ oc get namespaces | grep catalog
openshift-service-catalog-apiserver-operator            Active   112m
openshift-service-catalog-controller-manager-operator   Active   159m
  • service-catalog operators are in their initial state
[jesusr@transam cluster-svcat-controller-manager-operator{master}]$ oc get clusteroperator | grep catalog               
operator-lifecycle-manager-catalog         4.2.0-0.nightly-2019-08-27-105356   True        False         False      158m
service-catalog-apiserver                  4.2.0-0.nightly-2019-08-27-105356   True        False         False      14m 
service-catalog-controller-manager         4.2.0-0.nightly-2019-08-27-105356   True        False         False      14m 

@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 27, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2019
@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 29, 2019

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Aug 29, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@jmrodri jmrodri changed the title Bug 1710937 - delete owner reference from servicebindings Bug 1710937: delete owner reference from servicebindings Sep 6, 2019
@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 6, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2019
@openshift-ci-robot
Copy link

@jmrodri: An error was encountered searching for bug 1710937 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1710937?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1710937: delete owner reference from servicebindings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 9, 2019

@joelanford @shawn-hurley just a friendly reminder.

@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 10, 2019

/retest

@joelanford
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 10, 2019

/retest

@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 11, 2019

/test e2e-aws

1 similar comment
@jmrodri
Copy link
Contributor Author

jmrodri commented Sep 11, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 4b82e64 into openshift:master Sep 11, 2019
@openshift-ci-robot
Copy link

@jmrodri: All pull requests linked via external trackers have merged. Bugzilla bug 1710937 has been moved to the MODIFIED state.

In response to this:

Bug 1710937: delete owner reference from servicebindings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmrodri jmrodri deleted the bz1710937 branch March 25, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants