Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the placeholder for the first test #1172

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add the placeholder for the first test #1172

wants to merge 3 commits into from

Conversation

hongkailiu
Copy link
Member

Will rebase after #1168 gets in.

@hongkailiu
Copy link
Member Author

/wip

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller March 27, 2025 13:36
petr-muller
petr-muller reviewed Mar 27, 2025
View reviewed changes
@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu hongkailiu force-pushed the pr1168 branch 2 times, most recently from b09111d to c9ec674 Compare March 31, 2025 18:51
@hongkailiu
Copy link
Member Author

/retest

@DavidHurta
Copy link
Contributor

/cc

@openshift-ci openshift-ci bot requested a review from DavidHurta April 2, 2025 12:38
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2025
@hongkailiu
Update vendor
0ff63c0
@hongkailiu
Add the placeholder for the first test
51be531
@hongkailiu
Use OpenShift's fork of Ginkgo
d42baa6 
The function BuildExtensionTestSpecsFromOpenShiftGinkgoSuite is
currently available only in OpenShift's fork of Ginkgo.
See the "replace" directive in go.mod copied from [1].

[1]. https://github.com/openshift-eng/openshift-tests-extension/blob/8ef37c67e666954f9b95e52320c9c20d6b53d241/go.mod#L37
@hongkailiu hongkailiu requested a review from petr-muller April 2, 2025 14:42
@hongkailiu
Copy link
Member Author

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-operator-devpreview d42baa6 link false /test e2e-agnostic-operator-devpreview
ci/prow/okd-scos-e2e-aws-ovn d42baa6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift d42baa6 link true /test e2e-hypershift
ci/prow/e2e-agnostic-usc-devpreview f6ebe71 link false /test e2e-agnostic-usc-devpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongkailiu @petr-muller @DavidHurta @openshift-merge-robot