NO-JIRA: Add unit test for renderManifest

[hongkailiu]

The diff makes sense, of course.

$ cat ./install/0000_00_cluster-version-operator_03_deployment.yaml | grep '{{'
        image: {{.ReleaseImage}}
          - "--release-image={{.ReleaseImage}}"
            value: {{ .ClusterProfile }}

$ diff -Naupr install/0000_00_cluster-version-operator_03_deployment.yaml pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml    
--- install/0000_00_cluster-version-operator_03_deployment.yaml 2024-11-06 13:30:42
+++ pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml        2025-03-27 09:59:50
@@ -25,11 +25,11 @@ spec:
       automountServiceAccountToken: false
       containers:
       - name: cluster-version-operator
-        image: {{.ReleaseImage}}
+        image: quay.io/cvo/release:latest
         imagePullPolicy: IfNotPresent
         args:
           - "start"
-          - "--release-image={{.ReleaseImage}}"
+          - "--release-image=quay.io/cvo/release:latest"
           - "--enable-auto-update=false"
           - "--listen=0.0.0.0:9099"
           - "--serving-cert-file=/etc/tls/serving-cert/tls.crt"
@@ -70,7 +70,7 @@ spec:
               fieldRef:
                 fieldPath: spec.nodeName
           - name: CLUSTER_PROFILE
-            value: {{ .ClusterProfile }}
+            value: some-profile
       # this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
       # this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
       dnsPolicy: Default

/cc @petr-muller

[petr-muller]

/label no-qe
/label acknowledge-critical-fixes-only

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[petr-muller]

/retitle NO-JIRA: Add unit test for renderManifest

[openshift-ci-robot]

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

The diff makes sense, of course.

$ cat ./install/0000_00_cluster-version-operator_03_deployment.yaml | grep '{{'
       image: {{.ReleaseImage}}
         - "--release-image={{.ReleaseImage}}"
           value: {{ .ClusterProfile }}

$ diff -Naupr install/0000_00_cluster-version-operator_03_deployment.yaml pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml    
--- install/0000_00_cluster-version-operator_03_deployment.yaml 2024-11-06 13:30:42
+++ pkg/payload/testdata/TestRenderManifest_expected_cvo_deployment.yaml        2025-03-27 09:59:50
@@ -25,11 +25,11 @@ spec:
      automountServiceAccountToken: false
      containers:
      - name: cluster-version-operator
-        image: {{.ReleaseImage}}
+        image: quay.io/cvo/release:latest
        imagePullPolicy: IfNotPresent
        args:
          - "start"
-          - "--release-image={{.ReleaseImage}}"
+          - "--release-image=quay.io/cvo/release:latest"
          - "--enable-auto-update=false"
          - "--listen=0.0.0.0:9099"
          - "--serving-cert-file=/etc/tls/serving-cert/tls.crt"
@@ -70,7 +70,7 @@ spec:
              fieldRef:
                fieldPath: spec.nodeName
          - name: CLUSTER_PROFILE
-            value: {{ .ClusterProfile }}
+            value: some-profile
      # this pod is hostNetwork and uses the internal LB DNS name when possible, which the kubelet also uses.
      # this dnsPolicy allows us to use the same dnsConfig as the kubelet, without access to read it ourselves.
      dnsPolicy: Default

/cc @petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4ec8c48 and 2 for PR HEAD e543674 in total

[petr-muller]

/override ci/prow/e2e-agnostic-ovn

Single unrelated test failed:

: [bz-etcd][invariant] alert/etcdHighCommitDurations should not be at or above 

[openshift-ci]

@petr-muller: Overrode contexts on behalf of petr-muller: ci/prow/e2e-agnostic-ovn

In response to this:

/override ci/prow/e2e-agnostic-ovn

Single unrelated test failed:

: [bz-etcd][invariant] alert/etcdHighCommitDurations should not be at or above 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	e543674	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-version-operator
This PR has been included in build cluster-version-operator-container-v4.20.0-202503271738.p0.gddb11b3.assembly.stream.el9.
All builds following this will include this PR.