-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Fixing flake EnsureKubeAPIDNSName E2E test #5940
Conversation
This PR tries to win some time for investigation why this error 409 happens once the clients tries to update the HC obbject with the new field kubeAPIServerDNSName Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
This PR get the latest revision of the HC object before updating it, with that we make sure we updating the latest version of the object avoiding the error 409 Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@jparrill: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
6 similar comments
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
Putting the PR out of draft, looks the flakiness of the EnsureKubeAPIDNSName tests is not there anymore |
/lgtm |
/test e2e-aks |
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main" |
@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest e2e-aks |
@jparrill: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-aks |
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main" |
@jparrill: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
This E2E will be removed in this other PR: #5968. Closing |
@jparrill: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR get the latest revision of the HC object before updating it, with that we make sure we updating the latest version of the object avoiding the error 409.
Thread: https://redhat-internal.slack.com/archives/G01QS0P2F6W/p1743426856541079
Flakiness report: