Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Fixing flake EnsureKubeAPIDNSName E2E test #5940

Closed
wants to merge 2 commits into from

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Mar 31, 2025

This PR get the latest revision of the HC object before updating it, with that we make sure we updating the latest version of the object avoiding the error 409.

Thread: https://redhat-internal.slack.com/archives/G01QS0P2F6W/p1743426856541079

Flakiness report:

Index Status Link Reason
1 🔴 Link Non-related CI Issue
2 🟢 Link N/A
3 🔴 Link Non-related CI Issue
4 🔴 Link Non-related CI Issue
5 🟢 Link N/A
6 🟢 Link N/A

This PR tries to win some time for investigation why this error 409 happens once the clients tries to update the HC obbject with the new field kubeAPIServerDNSName

Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
This PR get the latest revision of the HC object before updating it, with that we make sure we updating the latest version of the object avoiding the error 409

Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2025
@openshift-ci-robot
Copy link

@jparrill: This pull request explicitly references no jira issue.

In response to this:

This PR get the latest revision of the HC object before updating it, with that we make sure we updating the latest version of the object avoiding the error 409.

Thread: https://redhat-internal.slack.com/archives/G01QS0P2F6W/p1743426856541079

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area labels Mar 31, 2025
Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Mar 31, 2025
Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Mar 31, 2025
@jparrill
Copy link
Contributor Author

/test e2e-aws

6 similar comments
@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2025

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2025

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2025

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2025

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 1, 2025

/test e2e-aws

@jparrill
Copy link
Contributor Author

jparrill commented Apr 2, 2025

/test e2e-aws

@jparrill jparrill marked this pull request as ready for review April 2, 2025 07:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
@openshift-ci openshift-ci bot requested review from csrwng and hasueki April 2, 2025 07:38
@jparrill
Copy link
Contributor Author

jparrill commented Apr 2, 2025

Putting the PR out of draft, looks the flakiness of the EnsureKubeAPIDNSName tests is not there anymore

@bryan-cox
Copy link
Member

/lgtm

@bryan-cox
Copy link
Member

/test e2e-aks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2025
@sjenning
Copy link
Contributor

sjenning commented Apr 2, 2025

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3283bb9 and 2 for PR HEAD d9d2bf6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd119b4 and 1 for PR HEAD d9d2bf6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fd119b4 and 2 for PR HEAD d9d2bf6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dcd4b68 and 1 for PR HEAD d9d2bf6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1de2692 and 0 for PR HEAD d9d2bf6 in total

@jparrill
Copy link
Contributor Author

jparrill commented Apr 3, 2025

/retest e2e-aks

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@jparrill: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aks
/test e2e-aks-4-18
/test e2e-aws
/test e2e-aws-4-18
/test e2e-aws-override
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test images
/test security
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-karpenter-core
/test e2e-aws-metrics
/test e2e-aws-techpreview
/test e2e-azure-aks-ovn-conformance
/test e2e-conformance
/test e2e-kubevirt-aws-ovn
/test e2e-kubevirt-azure-ovn
/test e2e-kubevirt-metal-conformance
/test e2e-openstack-aws
/test e2e-openstack-aws-conformance
/test e2e-openstack-aws-csi-cinder
/test e2e-openstack-aws-csi-manila
/test e2e-openstack-aws-nfv
/test okd-scos-e2e-aws-ovn
/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-hypershift-main-e2e-aks
pull-ci-openshift-hypershift-main-e2e-aks-4-18
pull-ci-openshift-hypershift-main-e2e-aws
pull-ci-openshift-hypershift-main-e2e-aws-4-18
pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
pull-ci-openshift-hypershift-main-images
pull-ci-openshift-hypershift-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-hypershift-main-security
pull-ci-openshift-hypershift-main-unit
pull-ci-openshift-hypershift-main-verify

In response to this:

/retest e2e-aks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

jparrill commented Apr 3, 2025

/test e2e-aks

@jparrill
Copy link
Contributor Author

jparrill commented Apr 3, 2025

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@jparrill: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aks
  • ci/prow/e2e-aks-4-18
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-4-18
  • ci/prow/e2e-aws-upgrade-hypershift-operator
  • ci/prow/e2e-kubevirt-aws-ovn-reduced
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aks-4-18
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-aws-4-18
  • pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-hypershift-main-security
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jparrill
Copy link
Contributor Author

jparrill commented Apr 3, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 3, 2025
@jparrill
Copy link
Contributor Author

jparrill commented Apr 3, 2025

This E2E will be removed in this other PR: #5968. Closing

@jparrill jparrill closed this Apr 3, 2025
Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@jparrill: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants