Authenticate to registries when pulling images #206
Conversation
When we attempt to pull images, use authentication secrets, if we can find some that match. We special-case docker.io and locations that end in .docker.io to also check for authentication information tagged for either docker.io, index.docker.io, or https://index.docker.io/v1/. Signed-off-by: Nalin Dahyabhai <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM |
|
Changs LGTM |
|
Add tests in a subsequent PR. |
| } | ||
| if domain == "docker.io" || strings.HasSuffix(domain, ".docker.io") { | ||
| var auths []dockertypes.AuthConfig | ||
| for _, aka := range []string{"docker.io", "index.docker.io", "https://index.docker.io/v1/"} { |
There was a problem hiding this comment.
@nalind I think single auth credential would work for all if them "docker.io", "index.docker.io", "https://index.docker.io/v1/". If individual entries for each of them is found it would return with three similar auth credentials.
Instead of append we could a return I think.
There was a problem hiding this comment.
Yes, the caller (ClientExecutor.LoadImage) will try them all, stopping after any of them succeed.
|
I am late. PR looks good to me just one doubt and its a non-blocker @nalind PTAL |
When we attempt to pull images, use authentication secrets, if we can find some that match. We special-case docker.io and locations that end in .docker.io to also check for authentication information tagged for either docker.io, index.docker.io, or https://index.docker.io/v1/.
Fixes #144.