TestUploadNotDelayedAfterStart #157
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
psimovec
force-pushed
the
nodelay
branch
3 times, most recently
from
8965b4a to
cab86d5
Compare
psimovec
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test e2e-aws |
|
/retest |
test/integration/main_test.go
Outdated
| @@ -183,7 +183,16 @@ func deleteAllPods(t *testing.T, namespace string) { | |||
| t.Log(errPod) | |||
| } | |||
|
|
|||
| func checkPodsLogs(t *testing.T, kubeClient *kubernetes.Clientset, message string, newLogsOnly ...bool) { | |||
| func logLineTime(t *testing.T, pattern string) time.Time { | |||
| str := checkPodsLogs(t, clientset, `\d+:\d+:\d+\.\d+.*`+pattern) | |||
There was a problem hiding this comment.
Maybe it would be a bit safer to read from beginning of the line, like:
^\S\d{2}\d{2}\s\d+:\d+:\d+\.\d+.*
to parse pattern:
I0721 13:37:20.340873
This could help to skip potential lines which have time in the middle of log message
There was a problem hiding this comment.
nice catch!
unfortunately, there are no newlines in captured logs, which is quite weird.. so "^" does not work. I made it at least more specific with an additional check. Now there would be problem if log line contained whole different log line, which I don't expect to happen much...
psimovec
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
psimovec
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -20,6 +20,18 @@ const knownFileSuffixesInsideArchiveRegex string = `(`+ | |||
| `(\/|^)(config|id|invoker|metrics|version)` + | |||
| `)$` | |||
|
|
|||
| //https://bugzilla.redhat.com/show_bug.cgi?id=1841057 | |||
| func TestUploadNotDelayedAfterStart(t *testing.T) { | |||
| time1:=logLineTime(t, `Reporting status periodically to .* every`) | |||
There was a problem hiding this comment.
Nice, Could we please just for sure check that IO operator is healthy at the beginning of TC, because that is precondition for fast upload mode.
Also, at the beginning of Log file should be It is safe to use fast upload and not Not safe for fast upload, but I guess checking health of operator should be good enough fot test. (To not to have investigate ccases when AWS or OCP itself failed).
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkunc, psimovec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
https://bugzilla.redhat.com/show_bug.cgi?id=1841057