Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1881816: Gather MachineSet info #183

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Bug 1881816: Gather MachineSet info #183

merged 1 commit into from
Sep 24, 2020

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Sep 21, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@tremes
Copy link
Contributor Author

tremes commented Sep 22, 2020

Can you please review @natiiix, @martinkunc ?

@0sewa0
Copy link
Contributor

0sewa0 commented Sep 22, 2020

lgtm

@martinkunc
Copy link
Contributor

/retest

@tremes tremes changed the title WIP Gather MachineSet info Bug 1881816: Gather MachineSet info Sep 23, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1881816, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1881816: Gather MachineSet info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Sep 23, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@tremes: This pull request references Bugzilla bug 1881816, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 23, 2020
tremes
tremes commented Sep 23, 2020
View reviewed changes
tremes
tremes commented Sep 23, 2020
View reviewed changes
pkg/gather/clusterconfig/clusterconfig_test.go
}
if records[0].Name != "machinesets/test-worker" {
t.Fatalf("unexpected machineset name %s", records[0].Name)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty simple test, but I was struggling with unmarshalling the record to something meaningful (wasn't successful with Unstructured).

@tremes tremes changed the title Bug 1881816: Gather MachineSet info WIP Bug 1881816: Gather MachineSet info Sep 23, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2020
@tremes tremes changed the title WIP Bug 1881816: Gather MachineSet info Bug 1881816: Gather MachineSet info Sep 23, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2020
@martinkunc
Copy link
Contributor

Great PR, thanks Tomas,

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martinkunc, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 809f433 into openshift:master Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 1881816 has been moved to the MODIFIED state.

In response to this:

Bug 1881816: Gather MachineSet info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes deleted the machineset branch September 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

@natiiix natiiix Awaiting requested review from natiiix

Assignees

@martinkunc martinkunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tremes @0sewa0 @martinkunc @openshift-ci-robot @openshift-bot @openshift-merge-robot