Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds github pull request template. #282

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Adds github pull request template. #282

merged 3 commits into from
Dec 9, 2020

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Dec 4, 2020 •
edited by openshift-ci-robot
Loading

This PR adds the Github PR template as CCXDEV-3569 requests.

Sample repository:
https://github.com/rluders/github-templates-test

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@tremes
Copy link
Contributor

tremes commented Dec 4, 2020

I would change the order of the parts as in the proposal. The testing should be second and so on.

@rluders rluders requested review from tremes and 0sewa0 December 7, 2020 10:50
@0sewa0
Copy link
Contributor

0sewa0 commented Dec 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rluders
Copy link
Contributor Author

rluders commented Dec 7, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rluders
Copy link
Contributor Author

rluders commented Dec 8, 2020

/retest

@tremes
Copy link
Contributor

tremes commented Dec 8, 2020

/test insights-operator-e2e-tests

@tremes
Copy link
Contributor

tremes commented Dec 8, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rluders
Copy link
Contributor Author

rluders commented Dec 8, 2020

/test insights-operator-e2e-tests

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ed87791 into openshift:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@psimovec psimovec Awaiting requested review from psimovec

@tremes tremes Awaiting requested review from tremes

@0sewa0 0sewa0 Awaiting requested review from 0sewa0

Assignees

@0sewa0 0sewa0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rluders @tremes @0sewa0 @openshift-ci-robot @openshift-bot @openshift-merge-robot