-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap license management logs gatherer #342
sap license management logs gatherer #342
Conversation
/retest |
@Sergey1011010: This pull request references Bugzilla bug 1928512, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Sergey1011010: This pull request references Bugzilla bug 1928512, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Sergey1011010 No need for bugzilla at the moment (we are not in feature freeze) |
@Sergey1011010: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not giving it an approval right now because I don't want to accidentally trigger the auto-merge. The code is fine now. I have no more serious issues with it.
It would be nice to have something in the sample archive. Is there some problem with reproducing the error? Maybe Michal can help us? Maybe he has some example log? |
datahubGroupVersionResource = schema.GroupVersionResource{ | ||
Group: "installers.datahub.sap.com", Version: "v1alpha1", Resource: "datahubs", | ||
} | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have const.go
after last Marcell commit. Please put it there.
One last comment from me, but otherwise LGTM. Thanks!!!! |
@tremes I wasn't able to reproduce the error, but I guess the string would be "iptables v1.6.2: can't initialize iptables table `nat': Permission denied" |
I verified only basic run on cluster without SAP, but the changes look reasonable. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sergey1011010, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tested on SAP cluster with different substrings.
Categories
Sample archive
No changes
Documentation
docs/gathered-data.md
Unit Tests
No changes
Privacy
Yes. There are no sensitive data in the newly collected information.
References
https://issues.redhat.com/browse/CCXDEV-3484
https://bugzilla.redhat.com/show_bug.cgi?id=1928512
https://access.redhat.com/articles/5100521#license-manager-cannot-be-initialized