Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap license management logs gatherer #342

Conversation

Serhii1011010
Copy link
Contributor

@Serhii1011010 Serhii1011010 commented Feb 12, 2021

The SAP installation may fail in license management pod, so We need error logs to detect the failure.

Get the filtered error logs as followings.

# oc logs deploy/license-management-l4rvh
Found 2 pods, using pod/license-management-l4rvh-74595f8c9b-flgz9
+ iptables -D PREROUTING -t nat -j VSYSTEM-AGENT-PREROUTING
+ true
+ iptables -F VSYSTEM-AGENT-PREROUTING -t nat
+ true
+ iptables -X VSYSTEM-AGENT-PREROUTING -t nat
+ true
+ iptables -N VSYSTEM-AGENT-PREROUTING -t nat
iptables v1.6.2: can't initialize iptables table `nat': Permission denied
Perhaps iptables or your kernel needs to be upgraded.

Tested on SAP cluster with different substrings.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

No changes

Documentation

  • docs/gathered-data.md

Unit Tests

No changes

Privacy

Yes. There are no sensitive data in the newly collected information.

References

https://issues.redhat.com/browse/CCXDEV-3484
https://bugzilla.redhat.com/show_bug.cgi?id=1928512
https://access.redhat.com/articles/5100521#license-manager-cannot-be-initialized

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

@Serhii1011010 Serhii1011010 changed the title [WIP] sap license management logs gatherer Bug 1928512: sap license management logs gatherer Feb 14, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 14, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1928512, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1928512: sap license management logs gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 14, 2021
@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 14, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: This pull request references Bugzilla bug 1928512, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented Feb 15, 2021

@Sergey1011010 No need for bugzilla at the moment (we are not in feature freeze)

@Serhii1011010 Serhii1011010 changed the title Bug 1928512: sap license management logs gatherer sap license management logs gatherer Feb 15, 2021
@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 15, 2021
@openshift-ci-robot
Copy link
Contributor

@Sergey1011010: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

sap license management logs gatherer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 15, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not giving it an approval right now because I don't want to accidentally trigger the auto-merge. The code is fine now. I have no more serious issues with it.

@tremes
Copy link
Contributor

tremes commented Feb 19, 2021

It would be nice to have something in the sample archive. Is there some problem with reproducing the error? Maybe Michal can help us? Maybe he has some example log?

datahubGroupVersionResource = schema.GroupVersionResource{
Group: "installers.datahub.sap.com", Version: "v1alpha1", Resource: "datahubs",
}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have const.go after last Marcell commit. Please put it there.

@tremes
Copy link
Contributor

tremes commented Feb 19, 2021

One last comment from me, but otherwise LGTM. Thanks!!!!

@Serhii1011010
Copy link
Contributor Author

@tremes I wasn't able to reproduce the error, but I guess the string would be "iptables v1.6.2: can't initialize iptables table `nat': Permission denied"

@tremes
Copy link
Contributor

tremes commented Feb 23, 2021

I verified only basic run on cluster without SAP, but the changes look reasonable.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit afe161a into openshift:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants