Update relatedObjects #353
Conversation
openshift-ci-robot
added
the
approved
|
@wking Can you please check? |
| @@ -200,7 +200,12 @@ func (c *Controller) merge(existing *configv1.ClusterOperator) *configv1.Cluster | |||
| if len(c.namespace) > 0 { | |||
| existing.Status.RelatedObjects = []configv1.ObjectReference{ | |||
| {Resource: "namespaces", Name: c.namespace}, | |||
| {Group: "apps", Resource: "deployments", Namespace: c.namespace, Name: "insights-operator"}, | |||
| {Resource: "secrets", Namespace: "openshift-config", Name: "pull-secret"}, | |||
| {Resource: "secrets", Namespace: "openshift-config", Name: "support"}, | |||
There was a problem hiding this comment.
This one is kinda optional, but we try to read it so I think it makes sense to include it.
| {Resource: "serviceaccounts", Namespace: c.namespace, Name: "gather"}, | ||
| {Resource: "serviceaccounts", Namespace: c.namespace, Name: "operator"}, | ||
| {Resource: "services", Namespace: c.namespace, Name: "metrics"}, | ||
| {Resource: "configmaps", Namespace: c.namespace, Name: "service-ca-bundle"}, |
There was a problem hiding this comment.
| @@ -200,7 +200,12 @@ func (c *Controller) merge(existing *configv1.ClusterOperator) *configv1.Cluster | |||
| if len(c.namespace) > 0 { | |||
| existing.Status.RelatedObjects = []configv1.ObjectReference{ | |||
| {Resource: "namespaces", Name: c.namespace}, | |||
| {Group: "apps", Resource: "deployments", Namespace: c.namespace, Name: "insights-operator"}, | |||
There was a problem hiding this comment.
Well I think we can keep this one...
There was a problem hiding this comment.
You can keep it if you like, but deployments that live in referenced namespaces are covered too.
tremes
force-pushed
the
updated_relatedObjects
branch
from
4f3e5c3 to
f169a0a
Compare
|
A simple change, just reading it and seems pretty good. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rluders, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated our
ClusterOperatorrelatedObjects.Categories
Sample archive
No new data
Documentation
No update.
Unit Tests
No new test
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???