Bug 1940432: Gahter datahubs.installers.datahub.sap.com resources from SAP clusters #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
approved
natiiix
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@natiiix: This pull request references Bugzilla bug 1940432, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@natiiix: This pull request references Bugzilla bug 1940432, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@natiiix: This pull request references Bugzilla bug 1940432, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tremes
reviewed
Mar 19, 2021
| @@ -0,0 +1 @@ | |||
| {"apiVersion":"installers.datahub.sap.com/v1alpha1","kind":"DataHub","metadata":{"annotations":{"com.sap.datahub.installers.dependency.runlevel-mark":"preRunLevelStarted"},"creationTimestamp":"2021-01-25T16:47:32Z","finalizers":["com.sap.datahub.installers.dependency","datahub-controller.datahub.sap.com"],"generation":1,"managedFields":[{"apiVersion":"installers.datahub.sap.com/v1alpha1","fieldsType":"FieldsV1","fieldsV1":{"f:spec":{".":{},"f:auditlog":{".":{},"f:mode":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{}},"f:backupCleanupCronSchedule":{},"f:backupCronSchedule":{},"f:backupRetentionPeriod":{},"f:clusterID":{},"f:consul":{".":{},"f:UiService":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:overrides":{},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:replicas":{},"f:resources":{".":{},"f:limits":{},"f:requests":{}}},"f:deploymentType":{},"f:deployments":{},"f:diagnostic":{".":{},"f:docker":{},"f:elasticsearch":{".":{},"f:enabled":{},"f:watermark":{}},"f:fluentd":{".":{},"f:elasticsearchExporter":{},"f:enabled":{},"f:varlibdockercontainers":{}},"f:grafana":{".":{},"f:enabled":{},"f:urlBasePath":{}},"f:images":{".":{},"f:authProxy":{},"f:debian":{},"f:elasticsearch":{},"f:fluentd":{},"f:grafana":{},"f:kibana":{},"f:kubeStateMetrics":{},"f:nodeExporter":{},"f:prometheus":{},"f:prometheusPushgateway":{}},"f:kibana":{".":{},"f:enabled":{},"f:urlBasePath":{}},"f:networkPolicies":{".":{},"f:enabled":{}},"f:nodeExporter":{},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:prometheusKubeStateMetrics":{".":{},"f:enabled":{}},"f:prometheusNodeExporter":{".":{},"f:enabled":{}},"f:prometheusPushgateway":{".":{},"f:enabled":{}},"f:prometheusServer":{".":{},"f:enabled":{}},"f:proxy":{},"f:rbac":{".":{},"f:enabled":{}},"f:resources":{".":{},"f:authProxy":{".":{},"f:resources":{}},"f:dockerBase":{".":{},"f:resources":{}},"f:elasticsearch":{".":{},"f:resources":{}},"f:fluentd":{".":{},"f:resources":{}},"f:grafana":{".":{},"f:resources":{}},"f:kibana":{".":{},"f:resources":{}},"f:prometheusKubeStateMetrics":{".":{},"f:resources":{}},"f:prometheusNodeExporter":{".":{},"f:resources":{}},"f:prometheusPushgateway":{".":{},"f:resources":{}},"f:prometheusServer":{".":{},"f:resources":{}}},"f:secop":{".":{},"f:docker":{}},"f:version":{},"f:volumes":{".":{},"f:elasticsearch":{},"f:prometheusServer":{}}},"f:hana":{".":{},"f:memoryRequest":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:syncSleepTimeInSeconds":{}},"f:networkPolicies":{".":{},"f:enabled":{}},"f:package":{},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:spark":{".":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:resources":{".":{},"f:limits":{},"f:requests":{}}},"f:storageGateway":{".":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:replicas":{},"f:resources":{".":{},"f:limits":{},"f:requests":{}},"f:ssl":{}},"f:textAnalysis":{".":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:resources":{".":{},"f:limits":{},"f:requests":{}},"f:serviceType":{}},"f:timeout":{},"f:uaa":{".":{},"f:configuration":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:passwordPolicy":{},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{}},"f:voraCluster":{".":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:template":{".":{},"f:components":{".":{},"f:catalog":{".":{},"f:replicas":{},"f:traceLevel":{}},"f:disk":{".":{},"f:antiAffinity":{".":{},"f:replica":{".":{},"f:enable":{}},"f:resource":{".":{},"f:enable":{},"f:selectors":{".":{},"f:vora-component":{}}}},"f:dbSpaceSize":{},"f:initialDelaySeconds":{},"f:largeMemoryLimit":{},"f:mainCacheMemoryLimit":{},"f:networkDriversList":{},"f:passwordSecretName":{},"f:pv":{".":{},"f:storageClassName":{}},"f:replicas":{},"f:storageSize":{},"f:temporaryCacheMemoryLimit":{},"f:terminationGracePeriodSeconds":{},"f:traceLevel":{}},"f:dlog":{".":{},"f:antiAffinity":{".":{},"f:replica":{".":{},"f:enable":{}},"f:resource":{".":{},"f:enable":{},"f:selectors":{".":{},"f:vora-component":{}}}},"f:bufferSize":{},"f:pv":{".":{},"f:storageClassName":{}},"f:raftPort":{},"f:rdsHTTPPort":{},"f:replicationFactor":{},"f:restore":{},"f:standbyFactor":{},"f:storageSize":{},"f:traceLevel":{}},"f:globalParameters":{".":{},"f:checkpoint":{".":{},"f:active":{},"f:afsiConnectionSecret":{},"f:afsiPath":{},"f:afsiType":{},"f:clientIncrementalRecordLimit":{},"f:clientIncrementalSizeLimit":{},"f:clientWriteMinDelay":{},"f:maxStreamCheckpoints":{},"f:pathSuffix":{}},"f:fsGroup":{},"f:healthCheck":{".":{},"f:deregisterTimeout":{},"f:initialDelaySeconds":{},"f:periodSeconds":{},"f:statefulsetEvictionTimeoutMinutes":{},"f:terminationGracePeriodSeconds":{}},"f:input":{".":{},"f:path":{}},"f:rbac":{},"f:runAsUser":{},"f:security":{".":{},"f:context":{},"f:contextRoot":{},"f:image":{}},"f:traceLevel":{},"f:useK8sDiscovery":{}},"f:landscape":{".":{},"f:bootstrapMode":{},"f:replicas":{},"f:traceLevel":{}},"f:relational":{".":{},"f:replicas":{},"f:traceLevel":{}},"f:txBroker":{".":{},"f:replicas":{},"f:traceLevel":{}},"f:txCoordinator":{".":{},"f:replicas":{},"f:traceLevel":{}}},"f:docker":{".":{},"f:image":{},"f:imagePullSecret":{}},"f:name":{},"f:version":{".":{},"f:component":{},"f:package":{}}}},"f:voraSecurityOperator":{".":{},"f:caKeyStore":{".":{},"f:key":{},"f:name":{}},"f:caTrustStore":{".":{},"f:key":{},"f:name":{}},"f:dhKeySize":{},"f:interCaKeyStore":{".":{},"f:key":{},"f:name":{}},"f:interCaTrustStore":{".":{},"f:key":{},"f:name":{}},"f:jwtSecretCaBundle":{".":{},"f:key":{},"f:name":{}},"f:jwtSecretKeyStore":{".":{},"f:key":{},"f:name":{}},"f:jwtSecretTrustStore":{".":{},"f:key":{},"f:name":{}},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:securityContexts":{".":{},"f:contexts":{},"f:secop":{".":{},"f:issuerURI":{}}},"f:tlsSecretCaBundle":{".":{},"f:key":{},"f:name":{}},"f:tlsSecretKeyStore":{".":{},"f:key":{},"f:name":{}},"f:tlsSecretTrustStore":{".":{},"f:key":{},"f:name":{}}},"f:vsystem":{".":{},"f:UAA":{".":{},"f:clientId":{},"f:deploy":{},"f:endpoint":{}},"f:auditlog":{".":{},"f:deploy":{},"f:endpoint":{},"f:use":{}},"f:deploymentInfo":{},"f:deploymentType":{},"f:hana":{".":{},"f:tls":{}},"f:initialUserCreation":{".":{},"f:secretName":{}},"f:internalComm":{".":{},"f:authClientID":{},"f:filename":{},"f:vrepClientID":{},"f:vsystemClientID":{}},"f:layerStrategies":{},"f:loadNFSModules":{},"f:networkPolicies":{".":{},"f:enabled":{}},"f:podSecurityPolicies":{".":{},"f:release":{}},"f:proxy":{},"f:removePolicy":{},"f:runlevel":{},"f:securityDevelopment":{".":{},"f:deploy":{}},"f:solutions":{},"f:tenants":{},"f:vRep":{},"f:vSystem":{".":{},"f:auditlogAddress":{},"f:clusterAdminHostnames":{},"f:features":{".":{},"f:apiGateway":{}},"f:serviceType":{}},"f:vflow":{".":{},"f:enabled":{}}}}},"manager":"dhinstaller","operation":"Update","time":"2021-01-25T16:47:32Z"},{"apiVersion":"installers.datahub.sap.com/v1alpha1","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:annotations":{".":{},"f:com.sap.datahub.installers.dependency.runlevel-mark":{}},"f:finalizers":{}},"f:status":{".":{},"f:conditions":{},"f:expiresAt":{},"f:reason":{},"f:startedAt":{},"f:state":{}}},"manager":"datahub-operator","operation":"Update","time":"2021-03-12T14:43:14Z"}],"name":"default","namespace":"sdi","resourceVersion":"38971794","selfLink":"/apis/installers.datahub.sap.com/v1alpha1/namespaces/sdi/datahubs/default","uid":"1efff0e0-d012-45da-810d-5df6c841da35"},"spec":{"auditlog":{"mode":"production","networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{}},"backupCleanupCronSchedule":"0 0 * * *","backupCronSchedule":"0 0 * * *","backupRetentionPeriod":1296000,"clusterID":"11bw3dz","consul":{"UiService":{},"networkPolicies":{"enabled":false},"overrides":"Storage: 2Gi","podSecurityPolicies":{"release":{}},"proxy":{},"replicas":3,"resources":{"limits":{},"requests":{}}},"deploymentType":"on-prem","deployments":["vsystem","storage-gateway","diagnostic","vora-cluster"],"diagnostic":{"docker":{},"elasticsearch":{"enabled":true,"watermark":{}},"fluentd":{"elasticsearchExporter":{},"enabled":true,"varlibdockercontainers":"/var/lib/docker/containers"},"grafana":{"enabled":true,"urlBasePath":"/app/diagnostics-grafana"},"images":{"authProxy":{},"debian":{},"elasticsearch":{},"fluentd":{},"grafana":{},"kibana":{},"kubeStateMetrics":{},"nodeExporter":{},"prometheus":{},"prometheusPushgateway":{}},"kibana":{"enabled":true,"urlBasePath":"/app/diagnostics-kibana"},"networkPolicies":{"enabled":false},"nodeExporter":{},"podSecurityPolicies":{"release":{}},"prometheusKubeStateMetrics":{"enabled":true},"prometheusNodeExporter":{"enabled":true},"prometheusPushgateway":{"enabled":true},"prometheusServer":{"enabled":true},"proxy":{},"rbac":{"enabled":false},"resources":{"authProxy":{"resources":{}},"dockerBase":{"resources":{}},"elasticsearch":{"resources":{}},"fluentd":{"resources":{}},"grafana":{"resources":{}},"kibana":{"resources":{}},"prometheusKubeStateMetrics":{"resources":{}},"prometheusNodeExporter":{"resources":{}},"prometheusPushgateway":{"resources":{}},"prometheusServer":{"resources":{}}},"secop":{"docker":{}},"version":{},"volumes":{"elasticsearch":{},"prometheusServer":{}}},"hana":{"memoryRequest":"6Gi","networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"syncSleepTimeInSeconds":30},"networkPolicies":{"enabled":false},"package":"3.1.13","podSecurityPolicies":{"release":{}},"proxy":{},"spark":{"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"resources":{"limits":{},"requests":{}}},"storageGateway":{"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"replicas":1,"resources":{"limits":{},"requests":{}},"ssl":{}},"textAnalysis":{"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"resources":{"limits":{},"requests":{}},"serviceType":"ClusterIP"},"timeout":3600,"uaa":{"configuration":{},"networkPolicies":{"enabled":false},"passwordPolicy":{},"podSecurityPolicies":{"release":{}},"proxy":{}},"voraCluster":{"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"template":{"components":{"catalog":{"replicas":"1","traceLevel":""},"disk":{"antiAffinity":{"replica":{"enable":true},"resource":{"enable":true,"selectors":{"vora-component":"tx-coordinator"}}},"dbSpaceSize":10240,"initialDelaySeconds":180,"largeMemoryLimit":3000,"mainCacheMemoryLimit":3000,"networkDriversList":"","passwordSecretName":"vora.conf.disk-password","pv":{"storageClassName":""},"replicas":"1","storageSize":"50Gi","temporaryCacheMemoryLimit":3000,"terminationGracePeriodSeconds":300,"traceLevel":""},"dlog":{"antiAffinity":{"replica":{"enable":true},"resource":{"enable":true,"selectors":{"vora-component":"disk"}}},"bufferSize":"4g","pv":{"storageClassName":""},"raftPort":"49876","rdsHTTPPort":"8700","replicationFactor":"1","restore":false,"standbyFactor":"0","storageSize":"50Gi","traceLevel":""},"globalParameters":{"checkpoint":{"active":true,"afsiConnectionSecret":"vora.conf.checkpoint-connection","afsiPath":"/dqp/lib","afsiType":"v2afsi_s3","clientIncrementalRecordLimit":"16384","clientIncrementalSizeLimit":"16777216","clientWriteMinDelay":"300000","maxStreamCheckpoints":"2","pathSuffix":"checkpoints-11bw3dz"},"fsGroup":999,"healthCheck":{"deregisterTimeout":"2m","initialDelaySeconds":60,"periodSeconds":60,"statefulsetEvictionTimeoutMinutes":0,"terminationGracePeriodSeconds":60},"input":{"path":"/mnt/input"},"rbac":false,"runAsUser":999,"security":{"context":"consumer","contextRoot":"/tmp/vora-security","image":""},"traceLevel":"info","useK8sDiscovery":true},"landscape":{"bootstrapMode":"auto","replicas":"1","traceLevel":""},"relational":{"replicas":"1","traceLevel":""},"txBroker":{"replicas":"1","traceLevel":""},"txCoordinator":{"replicas":"1","traceLevel":""}},"docker":{"image":"sap-p-and-i-big-data-vora/com.sap.datahub.linuxx86_64/vora-dqp","imagePullSecret":""},"name":"vora","version":{"component":"2.5.15","package":""}}},"voraSecurityOperator":{"caKeyStore":{"key":"","name":""},"caTrustStore":{"key":"","name":""},"dhKeySize":256,"interCaKeyStore":{"key":"","name":""},"interCaTrustStore":{"key":"","name":""},"jwtSecretCaBundle":{"key":"","name":""},"jwtSecretKeyStore":{"key":"","name":""},"jwtSecretTrustStore":{"key":"","name":""},"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"securityContexts":{"contexts":[{"consumer":{"initializers":[{"generate-certificates.sh":"generate-certificates.sh"},{"generate-dummy-secret.py":"generate-dummy-secret.py"}],"periodics":[{"renew-certificates.sh":"10368000 renew-certificates.sh"}],"secrets":[{"vora.conf.secop.jwtiss.truststore":"truststore"},{"vora.conf.secop.tlsconfig.ca-bundle":"ca_bundle"},{"vora.conf.secop.tlsconfig.keystore-dh":"keystore_dh"},{"vora.conf.secop.v2auth":"v2auth.conf"},{"vora.conf.secop.tlsconfig.inter-ca":"inter_ca"},{"vora.conf.secop.tlsconfig.inter-ca-keystore":"inter_ca_keystore"}],"template":"Vora Userstore Consumer"}},{"changeowner":{"initializers":[{"change-owner.sh":"change-owner.sh"}],"template":"Change Owner"}},{"default":{"secrets":[{"vora.conf.secop.tlsconfig.keystore":"keystore"},{"vora.conf.secop.tlsconfig.truststore":"truststore"},{"vora.conf.secop.tlsconfig.ca-bundle":"ca_bundle"},{"vora.conf.secop.tlsconfig.keystore-dh":"keystore_dh"},{"vora.conf.secop.tlsconfig.inter-ca":"inter_ca"},{"vora.conf.secop.tlsconfig.inter-ca-keystore":"inter_ca_keystore"}],"template":"Vora Default TLS Configuration NI","type":"tlsconfig"}},{"default":{"configmaps":[{"uaa.jinja2":"uaa.jinja2"}],"initializers":[{"generate-certificates.sh":"generate-certificates.sh uaa"},{"configure-uaa.py":"configure-uaa.py"},{"sync-zone-userstores.py":"sync-zone-userstores.py --restore"}],"periodics":[{"sync-zone-userstores.py":"10 sync-zone-userstores.py"},{"renew-certificates.sh":"10368000 renew-certificates.sh"}],"secrets":[{"vora.conf.secop.tlsconfig.ca-bundle":"ca_bundle"},{"vora.conf.secop.tlsconfig.inter-ca":"inter_ca"},{"vora.conf.secop.tlsconfig.inter-ca-keystore":"inter_ca_keystore"},{"vora.conf.secop.tlsconfig.truststore":"service_provider_cert"},{"vora.conf.secop.tlsconfig.keystore":"service_provider_key"}],"template":"UAA Service","type":"uaaservice"}},{"default":{"secrets":[{"vora.conf.secop.jwtiss.keystore":"keystore"},{"vora.conf.secop.jwtiss.truststore":"truststore"}],"template":"Vora JWT Issuer NI","type":"jwtiss"}},{"default":{"configmaps":[{"vora.conf.secop.htpasswd":"htpasswd"}],"periodics":[{"push-userstore.sh":"10 push_userstore.sh"}],"template":"Vora Userstore Producer","type":"userstore-producer"}},{"default":{"secrets":[{"vora.conf.secop.encryption-key":"encryption_key"}],"template":"Encryption Key","type":"encryptionkey"}},{"default":{"initializers":[{"prepare-validation-context.py":"prepare-validation-context.py vora.conf.secop.validation.cred"}],"template":"Validation Context","type":"validation"}},{"htpasswd":{"initializers":[{"pull-userstore.sh":"pull_userstore.sh"}],"periodics":[{"pull-userstore.sh":"10 pull_userstore.sh"}],"template":"Htpasswd"}}],"secop":{"issuerURI":"https://uaa:8080"}},"tlsSecretCaBundle":{"key":"","name":""},"tlsSecretKeyStore":{"key":"","name":""},"tlsSecretTrustStore":{"key":"","name":""}},"vsystem":{"UAA":{"clientId":"","deploy":false,"endpoint":""},"auditlog":{"deploy":false,"endpoint":"https://auditlog:3030","use":true},"deploymentInfo":{},"deploymentType":"on-prem","hana":{"tls":{}},"initialUserCreation":{"secretName":"vora.conf.initial.user"},"internalComm":{"authClientID":"","filename":"","vrepClientID":"","vsystemClientID":""},"layerStrategies":[{"name":"sdi-system-extension-strategy","parentStrategy":"strat-system-3.1.13"},{"name":"sdi-default-extension-strategy","parentStrategy":"strat-default-3.1.13"},{"layers":["installer-certificates","vrelease-diagnostics","vrelease-appmanagement","vora-tools","vsolution-vsystem-ui","vsolution-shared-ui","vsolution-app-base-db","data-tools-ui","license-manager","dsp-release-onprem-system"],"name":"strat-system-3.1.13"},{"layers":["installer-certificates","installer-configuration","vrelease-delivery-di","vsolution-app-base","vsolution-dh-flowagent","vrelease-appmanagement","vora-tools","vsolution-vsystem-ui","vsolution-shared-ui","vsolution-app-data","data-tools-ui","license-manager","dsp-release-onprem"],"name":"strat-default-3.1.13"}],"loadNFSModules":true,"networkPolicies":{"enabled":false},"podSecurityPolicies":{"release":{}},"proxy":{},"removePolicy":"keep","runlevel":{},"securityDevelopment":{"deploy":false},"solutions":[{"name":"installer-certificates","solutionFromContent":{"name":"certificates","secretSources":[{"secretKey":"vora.conf.secop.tlsconfig.ca-bundle","secretName":"vora.conf.secop.tlsconfig.ca-bundle","vrepPath":"ca/ca.crt"}],"version":"3.1.13"}},{"name":"installer-configuration","solutionFromContent":{"name":"installer_config","stringSources":[{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.registry\",\n \"description\": \"Modeler: Docker registry for Modeler images\",\n \"type\": \"string\",\n \"defaultValue\": \"container-image-registry-sdi-observer.apps.lab.hpecloud.org\"\n}\n","vrepPath":"vsystem/parameters/vflow.registry.json"},{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.aws.iamRole\",\n \"description\": \"Modeler: AWS IAM role for package version\",\n \"type\": \"string\",\n \"defaultValue\": \"\"\n}\n","vrepPath":"vsystem/parameters/vflow.aws.iamRole.json"},{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.registrySecret\",\n \"description\": \"Modeler: Name of the vSystem secret containing the credentials for Docker registry\",\n \"type\": \"string\",\n \"defaultValue\": \"vflow-secret\"\n}\n","vrepPath":"vsystem/parameters/vflow.registrySecret.json"},{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.imagePullSecret\",\n \"description\": \"Modeler: Docker image pull secret for Modeler\",\n \"type\": \"string\",\n \"defaultValue\": \"slp-docker-registry-pull-secret\"\n}\n","vrepPath":"vsystem/parameters/vflow.imagePullSecret.json"},{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.kanikoImage\",\n \"description\": \"Modeler: Kaniko build container image\",\n \"type\": \"string\",\n \"defaultValue\": \"container-image-registry-sdi-observer.apps.lab.hpecloud.org/kaniko-project/executor:v0.23.0\"\n}\n","vrepPath":"vsystem/parameters/vflow.kanikoImage.json"},{"contentString":"{\n \"apiVersion\": \"v2\",\n \"id\": \"vflow.baseRegistry\",\n \"description\": \"Modeler: Base registry for pulling images\",\n \"type\": \"string\",\n \"defaultValue\": \"container-image-registry-sdi-observer.apps.lab.hpecloud.org\"\n}\n","vrepPath":"vsystem/parameters/vflow.baseRegistry.json"}],"version":"3.1.13-ovmhx"}},{"name":"data-tools-ui"},{"name":"license-manager"},{"name":"vora-tools"},{"name":"vrelease-appmanagement"},{"name":"vrelease-delivery-di"},{"name":"vrelease-diagnostics"},{"name":"vsolution-app-base"},{"name":"vsolution-app-base-db"},{"name":"vsolution-app-data"},{"name":"vsolution-dh-flowagent"},{"name":"vsolution-shared-ui"},{"name":"vsolution-vsystem-ui"},{"name":"dsp-release-onprem"},{"name":"dsp-release-onprem-system"}],"tenants":[{"name":"system","strategyName":"sdi-system-extension-strategy","tenantAdminCreds":"vora.conf.initial.user","vsystemObjects":["{\n \"kind\": \"Route\",\n \"apiVersion\": \"v1\",\n \"metadata\": {\n \"name\": \"diagnostics-grafana\"\n },\n \"status\": {\n \"ingress\": [\n {\n \"host\": \"diagnostics-grafana\",\n \"port\": 443,\n \"tls\": true\n }\n ]\n }\n}\n","{\n \"kind\": \"Route\",\n \"apiVersion\": \"v1\",\n \"metadata\": {\n \"name\": \"diagnostics-kibana\"\n },\n \"status\": {\n \"ingress\": [\n {\n \"host\": \"diagnostics-kibana\",\n \"port\": 443,\n \"tls\": true\n }\n ]\n }\n}\n"]},{"name":"default","strategyName":"sdi-default-extension-strategy","tenantAdminCreds":"vora.conf.tenants.defaultadmin","vsystemSecrets":["vflow-secret"]}],"vRep":{},"vSystem":{"auditlogAddress":"https://auditlog:3030","clusterAdminHostnames":"vora-tx-coordinator,diagnostics-prometheus-server,storagegateway","features":{"apiGateway":{}},"serviceType":"ClusterIP"},"vflow":{"enabled":true}}},"status":{"conditions":[{"message":"Operation in progress","operationId":"3a248d","package":"3.1.13","reason":"preInstall","status":"False","timestamp":"2021-01-25T16:47:32Z","type":"inProgress"},{"message":"preInstall hooks successfully executed","operationId":"3a248d","package":"3.1.13","status":"True","timestamp":"2021-01-25T16:47:36Z","type":"preInstall"},{"message":"postInstall hooks successfully executed","operationId":"3a248d","package":"3.1.13","status":"True","timestamp":"2021-01-25T16:47:39Z","type":"postInstall"},{"message":"Operation in progress","operationId":"c03db8","package":"3.1.13","previousPackage":"3.1.13","reason":"preRunLevelStarted","status":"False","timestamp":"2021-01-25T16:47:43Z","type":"inProgress"},{"message":"preRunLevelStarted hooks successfully executed","operationId":"c03db8","package":"3.1.13","status":"True","timestamp":"2021-01-25T16:47:44Z","type":"preRunLevelStarted"},{"message":"postRunLevelStarted hooks successfully executed","operationId":"c03db8","package":"3.1.13","status":"True","timestamp":"2021-01-25T16:47:48Z","type":"postRunLevelStarted"}],"expiresAt":"2021-01-25T17:47:51Z","reason":"Expired","startedAt":"2021-01-25T16:47:51Z","state":"Failed"}} | |||
There was a problem hiding this comment.
Oh, I didn't notice we did that in the sample archive. I thought we kept things authentic.
tremes
reviewed
Mar 19, 2021
docs/gathered-data.md
Outdated
|
|
||
| collects `datahubs.installers.datahub.sap.com` resources from SAP/SDI clusters. | ||
|
|
||
| Location in archive: config/installers.datahub.sap.com/datahubs/<namespace>/<name>.json |
There was a problem hiding this comment.
Hmm we don't have any "third party" custom resources in the archive yet right? Just thinking if it's reasonable path...
Maybe config/customresources/installers.datahub.sap.com/.... if we have more in the future.
There was a problem hiding this comment.
I didn't want the path to be longer than what was strictly necessary because it is already a real pain to type. When we discussed the possibilities, this option seemed sufficiently specific that no one would confuse it. In fact, I would say that it would be best if all resources were stored in this format. I'd like to believe that in the future we are going to collect a lot more of these non-Kubernetes, non-OpenShift resources and I feel like it's a bit odd to put them into one directory even though they are not related. I can change it if you want, but it feels like the path is way too long then.
There was a problem hiding this comment.
I don't have a strong opinion TBH. I just wanted to discuss it. I think the length of the path doesn't play any role. I know that the structure of the IO archive is not ideal but I would like to keep it as clear as possible.
My feeling is that we're blindly putting everything under config. What about putting this CR to the root dir then? Just an idea...
There was a problem hiding this comment.
I was thinking the same, but we've been putting stuff into config/ for so long I was not brave enough to suggest putting anything elsewhere. I would say that resources that are gathered verbatim, without any preprocessing (except for potential anonymization where applicable) should be stored in a more formal structure. Either directly in the root of the archive or in a directory like resources/ or something. Then I'd suggest to use the most sensible directory structure based on the API group and resource name (API version should not be necessary, hopefully), followed by an optional namespace for non-cluster-wide resources and the name of the resource itself. This kind of a standardization, at least for non-core resources (like pods or nodes), should help us with organization of the archive in a more reasonable way than just throwing everything in config/. The only drawback is slightly more typing during development, but we would get a very clear picture of how the resources relate to each other on the API level. I'll bring this up on Monday's stand-up if I don't forget about it.
|
/retest |
|
/retest |
|
@natiiix: This pull request references Bugzilla bug 1940432, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I went through the code and did basic check on a cluster without SAP. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@natiiix: All pull requests linked via external trackers have merged: Bugzilla bug 1940432 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces another SAP enhancement. Much like the others, this one will also have to be backported to 4.6.z for us to see any useful results in a reasonable amount of time.
The presence of the Datahubs resource(s) is used for the identification of SAP (SDI) clusters. As such, it has been decided that it should be collected from all of them in order for the team processing the IO archives to be able to tell SAP clusters apart from the remaining clusters. It is possible that all of the data gathered exclusively from SAP clusters could be missing, in which case it would be impossible to determine if a cluster has an SDI installation or not. This enhancement fixes that issue by gathering a resource that should, universally, be present on all SAP clusters. By gathering this resource, we also safely know which namespace was SDI (attempted to be) installed into.
We came up with a hopefully reasonably clear and unambiguous directory structure for custom resources (see "Sample archive" section below), so please express raise your complaints now before it gets backported because we would like to use this for other custom resources (especially those that are not directly associated with OpenShift) in the future.
There is one one-line change in an unrelated gatherer's file. It's a little linter warning that I forgot to fix, but it's already fixed in all of the backports, so I wanted to fix it here as well. It will not appear in any of the backports of this enhancement.
Categories
Sample archive
docs/insights-archive-sample/customresources/installers.datahub.sap.com/datahubs/sdi/default.jsonDocumentation
docs/gathered-data.md- "SAPDatahubs" sectionUnit Tests
pkg/gather/clusterconfig/sap_datahubs_test.go-TestSAPDatahubsPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No.
References
Jira Task: https://issues.redhat.com/browse/CCXDEV-4228
Bugzilla Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1940432