Skip to content

Rename workload annotations #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

Rename workload annotations #405

merged 1 commit into from
Apr 29, 2021

Conversation

imiller0
Copy link
Contributor

As per openshift/enhancements#739, the workload
annotations names are changing.

/hold
Hold until after openshift/kubernetes#632 is merged please

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Documentation

openshift/enhancements#739

@imiller0
As per openshift/enhancements#739, the workload
900a2c2 
annotations names are changing.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2021
@imiller0
Copy link
Contributor Author

/retest

2 similar comments
@imiller0
Copy link
Contributor Author

/retest

@lack
Copy link
Member

lack commented Apr 20, 2021

/retest

@mrunalp mrunalp added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2021
@lack
Copy link
Member

lack commented Apr 20, 2021

/retest

2 similar comments
@lack
Copy link
Member

lack commented Apr 23, 2021

/retest

@lack
Copy link
Member

lack commented Apr 23, 2021

/retest

@tremes
Copy link
Contributor

tremes commented Apr 23, 2021

@lack @imiller0 do you still want to hold this one?

@imiller0
Copy link
Contributor Author

/unhold
openshift/kubernetes#632 has merged, please review and merge this PR as well.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@tremes
Copy link
Contributor

tremes commented Apr 27, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@lack
Copy link
Member

lack commented Apr 27, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 27, 2021

/retest

2 similar comments
@imiller0
Copy link
Contributor Author

/retest

@lack
Copy link
Member

lack commented Apr 27, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 27, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

2 similar comments
@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@lack
Copy link
Member

lack commented Apr 28, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9eb5bfb into openshift:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@imiller0 @lack @tremes @openshift-ci-robot @openshift-bot @mrunalp @openshift-merge-robot