-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1957889: Improves documentation of GatherClusterOperatorPodsAndEvents #420
Bug 1957889: Improves documentation of GatherClusterOperatorPodsAndEvents #420
Conversation
- Improves wording to make it clear what is collected and when. - Lists locations of individual data points so that users know where to look for the data even if they don't have a sample archive with the data (e.g. when starting an extraction notebook).
@jholecek-rh Thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jholecek-rh, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@jholecek-rh: This pull request references Bugzilla bug 1957889, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@jholecek-rh: This pull request references Bugzilla bug 1957889, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jholecek-rh: All pull requests linked via external trackers have merged: Bugzilla bug 1957889 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR improves documentation of GatherClusterOperatorPodsAndEvents:
look for the data even if they don't have a sample archive with the
data (e.g. when starting an extraction notebook).
Categories
Sample archive
N/A
Documentation
I need your help here. Is it preferred to update
gathered-data.md
with this type of changes or you do it once in a while? I didn't include an updated version ofgathered-data.md
because it included changes that I didn't do...Unit Tests
N/A
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
No.
References
https://coreos.slack.com/archives/CLABA9CHY/p1620223118250600?thread_ts=1620212876.245500&cid=CLABA9CHY