Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1961067: Collect full pod log for stack traces #421

Merged
merged 1 commit into from
May 19, 2021
Merged

Bug 1961067: Collect full pod log for stack traces #421

merged 1 commit into from
May 19, 2021

Conversation

rluders
Copy link
Contributor

@rluders rluders commented May 7, 2021 •
edited
Loading

This PR adds the capability to collect full container logs if the partial log contains possible stack traces.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

None.

Documentation

None.

Unit Tests

  • pkg/gatherers/clusterconfig/operators_pods_and_events_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

None.

References

https://issues.redhat.com/browse/CCXDEV-4600
https://bugzilla.redhat.com/show_bug.cgi?id=1961067

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from derekwaynecarr and mfojtik May 7, 2021 13:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@rluders rluders force-pushed the ccxdev-4600-improve-log-gathering-logic branch from 2fea71d to 8abde71 Compare May 10, 2021 08:56
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021
@rluders rluders force-pushed the ccxdev-4600-improve-log-gathering-logic branch from 4561950 to eeed9fa Compare May 13, 2021 08:08
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2021
Collect full pod log for stack traces
6c35f0e 
This adds the capability to collect full container logs if the partial log contains possible stack traces.

removing maxbytes and using buf.cap instead

Improve stack trace detector regex

Gets better log when it found stacktrace message on it
@rluders rluders force-pushed the ccxdev-4600-improve-log-gathering-logic branch from eeed9fa to 6c35f0e Compare May 14, 2021 13:25
@rluders rluders marked this pull request as ready for review May 14, 2021 13:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2021
@rluders rluders changed the title Collect full pod log for stack traces Bug 1961067: Collect full pod log for stack traces May 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@rluders: This pull request references Bugzilla bug 1961067, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1961067: Collect full pod log for stack traces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from psimovec May 17, 2021 07:28
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2021

@rluders: This pull request references Bugzilla bug 1961067, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1961067: Collect full pod log for stack traces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

natiiix
natiiix approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I tested locally that the IO runs and generates archives without errors.
Could you please fix the PR description a bit? It contains the default paths from the template.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented May 19, 2021

@rluders: This pull request references Bugzilla bug 1961067, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1961067: Collect full pod log for stack traces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b1a0fdf into openshift:master May 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2021

@rluders: All pull requests linked via external trackers have merged:

Bugzilla bug 1961067 has been moved to the MODIFIED state.

In response to this:

Bug 1961067: Collect full pod log for stack traces

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@natiiix natiiix natiiix approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mfojtik mfojtik Awaiting requested review from mfojtik

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@natiiix natiiix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluders @openshift-bot @tremes @natiiix @openshift-merge-robot