Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemoryRecord name can be obfuscated & fix case of duplicate records #444

Merged
merged 2 commits into from
Jun 16, 2021
Merged

MemoryRecord name can be obfuscated & fix case of duplicate records #444

merged 2 commits into from
Jun 16, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jun 4, 2021 •
edited
Loading

MemoryRecord name can be partially obfuscated as well (when includes cluster base domain i.e node names, hostsubnet names could contain <CLUSTER_BASE_DOMAIN> string). This means that such record couldn't be found in https://github.com/openshift/insights-operator/blob/master/pkg/recorder/recorder.go#L171 and the size was growing....and now we have enforced the size limit -> basically empty archives after some time when obfuscation is enabled, because the size limit was exceeded.

Also do not check the length of the data fingerprint (since it will be always 0 because we don't use fingerprints) -> fix the size counting in case of same duplicate records (yes it can happen as I found out).

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

No update

Unit Tests

No new test

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from iNecas and rluders June 4, 2021 07:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@tremes tremes changed the title MemoryRecord name can be obfuscated MemoryRecord name can be obfuscated & fix case of duplicate records Jun 4, 2021
@rluders
Copy link
Contributor

rluders commented Jun 4, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tremes tremes changed the title MemoryRecord name can be obfuscated & fix case of duplicate records Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records Jun 4, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 4, 2021

@tremes: This pull request references Bugzilla bug 1967949, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from psimovec June 4, 2021 13:51
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@tremes
Copy link
Contributor Author

tremes commented Jun 11, 2021

/test insights-operator-e2e-tests

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2021
@tremes tremes changed the title Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records WIP Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records Jun 11, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2021
@tremes
Copy link
Contributor Author

tremes commented Jun 14, 2021

/retest

@openshift-bot
Copy link
Contributor

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1967949, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes tremes changed the title WIP Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records Jun 15, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2021
@tremes tremes changed the title Bug 1967949: MemoryRecord name can be obfuscated & fix case of duplicate records MemoryRecord name can be obfuscated & fix case of duplicate records Jun 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2021

@tremes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

MemoryRecord name can be obfuscated & fix case of duplicate records

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2021
rluders
rluders approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5dcf37a into openshift:master Jun 16, 2021
tremes added a commit to tremes/insights-operator that referenced this pull request Jun 16, 2021
@tremes
MemoryRecord name can be obfuscated & fix case of duplicate records (o…
4368b47 
…penshift#444)

* MemoryRecord name can be obfuscated

* Just overwrite the records map when clearing
@tremes tremes mentioned this pull request Jun 16, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Jul 29, 2021
@tremes
MemoryRecord name can be obfuscated & fix case of duplicate records (#…
cd8b962 
…444) (#453)

* MemoryRecord name can be obfuscated

* Just overwrite the records map when clearing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@iNecas iNecas Awaiting requested review from iNecas

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremes @rluders @openshift-bot @openshift-merge-robot