Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add egress ips support to anonymizer #446

Merged
merged 4 commits into from
Jun 15, 2021
Merged

add egress ips support to anonymizer #446

merged 4 commits into from
Jun 15, 2021

Conversation

Serhii1011010
Copy link
Contributor

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No changes

Documentation

No changes

Unit Tests

No changes

Privacy

No new data was collected

Breaking Changes

Not really

References

https://issues.redhat.com/browse/CCXDEV-4864
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from natiiix and smarterclayton June 4, 2021 18:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@Serhii1011010 Serhii1011010 changed the title add egress ips support to anonymizer Bug 1968031: add egress ips support to anonymizer Jun 4, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 4, 2021

@Sergey1011010: This pull request references Bugzilla bug 1968031, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1968031: add egress ips support to anonymizer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 4, 2021
@Serhii1011010
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 4, 2021

@Sergey1011010: This pull request references Bugzilla bug 1968031, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from psimovec June 4, 2021 18:18
@Serhii1011010
Copy link
Contributor Author

/retest

1 similar comment
@Serhii1011010
Copy link
Contributor Author

/retest

rluders
rluders suggested changes Jun 8, 2021
View reviewed changes
pkg/anonymization/anonymizer.go Outdated
return nil, err
}

for _, hostSubnet := range hostSubnets.Items {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that the lint will complain about these two for, 'cause it will say that you should use index or pointer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check these links:
https://go-critic.github.io/overview#rangeValCopy-ref
https://stackoverflow.com/questions/20185511/range-references-instead-values

@tremes
Copy link
Contributor

tremes commented Jun 9, 2021

@Sergey1011010 would it be possible to test it (in our unit tests) please?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2021
@Serhii1011010 Serhii1011010 force-pushed the add-egress-ips-to-anonymizer branch from d720f60 to 2aec662 Compare June 9, 2021 15:42
@Serhii1011010
Copy link
Contributor Author

@tremes added the test

@Serhii1011010
Copy link
Contributor Author

/retest

1 similar comment
@Serhii1011010
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

@openshift-ci openshift-ci bot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1968031, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 14, 2021
tremes
tremes reviewed Jun 14, 2021
View reviewed changes
pkg/anonymization/anonymizer.go
@@ -83,7 +84,7 @@ type ConfigProvider interface {

// NewAnonymizer creates a new instance of anonymizer with a provided config observer and sensitive data
func NewAnonymizer(clusterBaseDomain string, networks []string, secretsClient corev1client.SecretInterface) (*Anonymizer, error) {
networks = append(networks, "127.0.0.1/8")
networks = append(networks, "127.0.0.0/8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change please? It's not clear to me at the first glance. We need to update also in the package doc - https://github.com/openshift/insights-operator/pull/446/files#diff-9180eb430c735bed4f79b7892293543fe58bd8bc57493f4f823ca84faa073f8eR12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a mistake in the original code, not really a problem cuz anonymizations would still work correctly, but /8 means everything after the first byte(127) should be zeros so that it's a valid mask.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see. Thx

@tremes
Copy link
Contributor

tremes commented Jun 15, 2021

Reviewed & tested. Please remove BZ Id and I also think it would be nice to backport it to 4.8. Thanks!!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sergey1011010, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sergey1011010,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Serhii1011010 Serhii1011010 changed the title Bug 1968031: add egress ips support to anonymizer add egress ips support to anonymizer Jun 15, 2021
@openshift-ci openshift-ci bot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2021

@Sergey1011010: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

add egress ips support to anonymizer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 15, 2021
@Serhii1011010
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a799c17 into openshift:master Jun 15, 2021
@Serhii1011010 Serhii1011010 mentioned this pull request Jun 22, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders requested changes

@tremes tremes tremes left review comments

@natiiix natiiix Awaiting requested review from natiiix

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Serhii1011010 @tremes @openshift-bot @rluders @openshift-merge-robot