Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2004814: OCM controller - change type of the secret #500

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Bug 2004814: OCM controller - change type of the secret #500

merged 1 commit into from
Sep 16, 2021

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Sep 14, 2021 •
edited
Loading

This changes the type of the etc-pki-entitlement secret to opaque. It also change the attribute names to end with pem suffix so that it can be easily consumed by the Build API.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

No doc update

Unit Tests

Corresponding unit tests updated.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=2004814
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@tremes tremes changed the title WIP OCM controller - change type of the secret Bug 2004814: OCM controller - change type of the secret Sep 16, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@tremes: This pull request references Bugzilla bug 2004814, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2004814: OCM controller - change type of the secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@tremes: This pull request references Bugzilla bug 2004814, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2004814: OCM controller - change type of the secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

natiiix
natiiix approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@natiiix natiiix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been discussed earlier in a video meeting. It's pretty straight-forward and I hope it won't break something unforeseeable in a significant way.
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2f2e2a0 into openshift:master Sep 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 16, 2021

@tremes: All pull requests linked via external trackers have merged:

Bugzilla bug 2004814 has been moved to the MODIFIED state.

In response to this:

Bug 2004814: OCM controller - change type of the secret

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Sep 17, 2021
@tremes
OCM controller - change type of the secret (openshift#500)
4e0b5b5
@openshift-ci openshift-ci bot mentioned this pull request Sep 17, 2021
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Nov 3, 2021
@tremes
[release-4.9] Bug 2005338: OCM controller - change type of the secret (…
1b491be 
…#500) (#506)

* OCM controller - change type of the secret (#500)

* Fix for linter
@tremes tremes deleted the ocm_secret_update branch November 26, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natiiix natiiix natiiix approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@tisnik tisnik Awaiting requested review from tisnik

Assignees

@natiiix natiiix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremes @openshift-bot @natiiix @openshift-merge-robot