Bug 2079315: Gather ODF config data #614
Conversation
mulbc
force-pushed
the
add-ODF-config-gathering
branch
from
c62ae2d to
35df02a
Compare
|
/retest lint |
|
@mulbc: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
lint fails because my new files are too similar to the existing openshift_logging files - what do you want to do? Ignore or refactor/merge? |
|
Few nits, but it works as expected and looks good to me. Thanks! I can approve once the linting is fixed. |
it is indeed a storageResourceList
I did copy and pasta this, but it's what we intended here
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mulbc, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@tremes - any idea why the upgrade tests are failing now? |
openshift-ci
bot
added
the
bugzilla/severity-unspecified
|
@mulbc: This pull request references Bugzilla bug 2079315, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@mulbc: This pull request references Bugzilla bug 2079315, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@tremes: This pull request references Bugzilla bug 2079315, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
removed
the
bugzilla/severity-unspecified
|
@tremes: This pull request references Bugzilla bug 2079315, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/severity-medium
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@mulbc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mulbc: All pull requests linked via external trackers have merged: Bugzilla bug 2079315 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds the collection of the ODF StorageCluster CR. If ODF is installed, there should be exactly one instance of this CR.
This PR follows the existing example of openshift-logging gathering.
Categories
Sample Archive
YES
Documentation
YES
Unit Tests
openshift_storage_test.go
Privacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Not yet - need advise on this
Breaking Changes
No breaking changes expected, new feature
References
https://issues.redhat.com/browse/CCXDEV-7908