Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new permanent clusteroperator conditions for SCA & #621

Merged
merged 2 commits into from
Jun 2, 2022
Merged

create new permanent clusteroperator conditions for SCA & #621

merged 2 commits into from
Jun 2, 2022

Conversation

tremes
Copy link
Contributor

@tremes tremes commented May 9, 2022

ClusterTransfer controllers

This creates new permanent clusteroperator conditions for the SimpleContentAccess and ClusterTransfer controller

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

The conditions will be documented in the README in a followup task

Unit Tests

Added

  • pkg/controllerstatus/controllerstatus_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2022
@openshift-ci openshift-ci bot requested review from rluders and tisnik May 9, 2022 11:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@tremes
Copy link
Contributor Author

tremes commented May 9, 2022

/test insights-operator-e2e-tests

@tremes tremes changed the title WIP create new permanent clusteroperator conditions for SCA & create new permanent clusteroperator conditions for SCA & May 10, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022
rluders
rluders approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just be checking the code it looks good. I also compiled and running it locally, just in case, didn't notice any issue.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes tremes mentioned this pull request May 18, 2022
Merged
4 tasks
@xJustin
Copy link
Contributor

xJustin commented May 19, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label May 19, 2022
@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 24, 2022
@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 31, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 3eada68 and 8 for PR HEAD 0e70aaf in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 3eada68 and 7 for PR HEAD 0e70aaf in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3eada68 and 6 for PR HEAD 0e70aaf in total

@tremes
Copy link
Contributor Author

tremes commented Jun 1, 2022

/test e2e-agnostic-upgrade

1 similar comment
@tremes
Copy link
Contributor Author

tremes commented Jun 2, 2022

/test e2e-agnostic-upgrade

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD b916a9c and 5 for PR HEAD 0e70aaf in total

@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0916e21 into openshift:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@tisnik tisnik Awaiting requested review from tisnik

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tremes @xJustin @JoaoFula @sferich888 @openshift-ci-robot @rluders @openshift-merge-robot