-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Prometheus Collector pattern #637
Implement Prometheus Collector pattern #637
Conversation
/test e2e-metal-ipi-ovn-ipv6 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d887b0d
to
911fff3
Compare
/test e2e-metal-ipi-ovn-ipv6 |
This is just update of previously merged and reverted commit. I can see the missing piece in the |
We added the update of the manifest required for the HyperShift deployment. |
/test e2e-metal-ipi-ovn-ipv6 |
/label px-approved |
This PR is an update of previously merged #607 (which was reverted). I am adding the remaining labels. |
@natiiix: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR changes the Prometheus metrics registry/server used by IO from the
legacyregistry
to an HTTP registry served directly from the IO code. An update of the Prometheus library was included in the changes to make sure the latest version of this dependency was used.In accordance with #635, the image references should be fixed now. Please see the additional optional test result below.
Manual Testing Steps
insights-operator
target is displayed as "up" and being properly scraped and that HTTPS is being used.insightsclient_*
metrics to make sure they are being reported.Categories
Sample Archive
N/A
Documentation
N/A
Unit Tests
N/A
Privacy
Yes. User data are not involved in the changes.
Changelog
Breaking Changes
No
References
Jira Task: https://issues.redhat.com/browse/CCXDEV-7475