Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Prometheus Collector pattern #637

Merged

Conversation

natiiix
Copy link
Contributor

@natiiix natiiix commented Jun 6, 2022

This PR changes the Prometheus metrics registry/server used by IO from the legacyregistry to an HTTP registry served directly from the IO code. An update of the Prometheus library was included in the changes to make sure the latest version of this dependency was used.

In accordance with #635, the image references should be fixed now. Please see the additional optional test result below.

Manual Testing Steps

  1. Start a testing cluster using the OCP image based on this PR (e.g., via cluster-bot).
  2. Check in the web console that the insights-operator target is displayed as "up" and being properly scraped and that HTTPS is being used.
  3. In the Metrics tab, try querying some of the insightsclient_* metrics to make sure they are being reported.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

N/A

Privacy

Yes. User data are not involved in the changes.

Changelog

Breaking Changes

No

References

Jira Task: https://issues.redhat.com/browse/CCXDEV-7475

@natiiix
Copy link
Contributor Author

natiiix commented Jun 6, 2022

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci openshift-ci bot requested review from rluders and tremes June 6, 2022 07:48
@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natiiix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2022
@natiiix natiiix force-pushed the metrics-collector-pattern branch from d887b0d to 911fff3 Compare June 6, 2022 08:01
@natiiix
Copy link
Contributor Author

natiiix commented Jun 6, 2022

/test e2e-metal-ipi-ovn-ipv6

@tremes
Copy link
Contributor

tremes commented Jun 6, 2022

This is just update of previously merged and reverted commit. I can see the missing piece in the manifests/image-references.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@tremes
Copy link
Contributor

tremes commented Jun 6, 2022

We added the update of the manifest required for the HyperShift deployment.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@natiiix
Copy link
Contributor Author

natiiix commented Jun 6, 2022

/test e2e-metal-ipi-ovn-ipv6

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jun 6, 2022
@tremes
Copy link
Contributor

tremes commented Jun 6, 2022

This PR is an update of previously merged #607 (which was reverted). I am adding the remaining labels.
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jun 6, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 5c7f142 and 8 for PR HEAD a0dfd56 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 5c7f142 and 7 for PR HEAD a0dfd56 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5c7f142 and 6 for PR HEAD a0dfd56 in total

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2022

@natiiix: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 062a9c7 into openshift:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants