Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-439: update the DVO metrics gatherer #664

Merged
merged 2 commits into from
Aug 25, 2022
Merged

OCPBUGS-439: update the DVO metrics gatherer #664

merged 2 commits into from
Aug 25, 2022

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Aug 23, 2022

The DVO metrics gatherer relied on the deployment-validation-operator namespace name, which is not very convenient, because it can be installed elsewhere.

Steps to verify:

  1. Install the deployment-validation-operator through the OperatorHub (it will be installed in the openshift-operators namespace).
  2. Create manually the metrics service for the DVO. You can use this definition. This should be fixed with the https://issues.redhat.com/browse/DVO-60
  3. Create some new namespace and deploy something (e.g the default httpd example) without the resource limits specified. This is required to introduce some DVO checks to be reported.
  4. Run IO gathering and check that the DVO metrics are gathered.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-439
https://access.redhat.com/solutions/???

@openshift-ci openshift-ci bot requested review from rluders and tisnik August 23, 2022 08:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@tremes tremes changed the title OCPBUGS-439 update the DVO metrics gatherer OCPBUGS-439: update the DVO metrics gatherer Aug 23, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

@tremes: This pull request references [Jira Issue OCPBUGS-439](https://issues.redhat.com//browse/OCPBUGS-439), which is invalid:

  • expected the bug to target the "4.12.0" version, but it targets "4.12" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

The DVO metrics gatherer relied on the deployment-validation-operator namespace name, which is not very convenient, because it can be installed elsewhere.

Steps to verify:

  1. Install the deployment-validation-operator through the OperatorHub (it will be installed in the openshift-operators namespace).
  2. Create manually the metrics service for the DVO. You can use this definition. This should be fixed with the https://issues.redhat.com/browse/DVO-60
  3. Create some new namespace and deploy something (e.g the default httpd example) without the resource limits specified. This is required to introduce some DVO checks to be reported.
  4. Run IO gathering and check that the DVO metrics are gathered.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-439
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor Author

tremes commented Aug 23, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 23, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022 •
edited by openshift-ci bot
Loading

@tremes: This pull request references [Jira Issue OCPBUGS-439](https://issues.redhat.com//browse/OCPBUGS-439), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula August 23, 2022 10:56
@tremes
Copy link
Contributor Author

tremes commented Aug 23, 2022

/retest

rluders
rluders approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and tested it.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD f9c4fe5 and 8 for PR HEAD 53f8138 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD f9c4fe5 and 7 for PR HEAD 53f8138 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f9c4fe5 and 6 for PR HEAD 53f8138 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@rluders
Copy link
Contributor

rluders commented Aug 25, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD f9c4fe5 and 8 for PR HEAD a17109e in total

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 210ef9b into openshift:master Aug 25, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 25, 2022 •
edited by openshift-ci bot
Loading

@tremes: All pull requests linked via external trackers have merged:

[Jira Issue OCPBUGS-439](https://issues.redhat.com//browse/OCPBUGS-439) has been moved to the MODIFIED state.

In response to this:

The DVO metrics gatherer relied on the deployment-validation-operator namespace name, which is not very convenient, because it can be installed elsewhere.

Steps to verify:

  1. Install the deployment-validation-operator through the OperatorHub (it will be installed in the openshift-operators namespace).
  2. Create manually the metrics service for the DVO. You can use this definition. This should be fixed with the https://issues.redhat.com/browse/DVO-60
  3. Create some new namespace and deploy something (e.g the default httpd example) without the resource limits specified. This is required to introduce some DVO checks to be reported.
  4. Run IO gathering and check that the DVO metrics are gathered.

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

No new data

Documentation

Unit Tests

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-439
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tremes added a commit to tremes/insights-operator that referenced this pull request Sep 15, 2022
@tremes
[release-4.11] OCPBUGS-1355: update the DVO metrics gatherer (openshi…
8f5280b 
…ft#664)

* OCPBUGS-439 update the DVO metrics gatherer

* Fix linting
@tremes tremes mentioned this pull request Sep 15, 2022
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Sep 19, 2022
@tremes
[release-4.11] OCPBUGS-1355: update the DVO metrics gatherer (#664) (#…
6c013e7 
…677)

* OCPBUGS-439 update the DVO metrics gatherer

* Fix linting
@tremes tremes deleted the fix-dvo-gatherer branch August 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@tisnik tisnik Awaiting requested review from tisnik

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremes @openshift-ci-robot @rluders @openshift-merge-robot