Introduce insightsoperators.openshift.io CR & implement its gather st… #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
|
You probably want to extend $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_insights-operator/666/pull-ci-openshift-insights-operator-master-e2e/1562059761355067392/artifacts/e2e/gather-extra/artifacts/clusteroperators.json | jq -c '.items[] | select(.metadata.name == "insights").status.relatedObjects[]'
{"group":"","name":"openshift-insights","resource":"namespaces"}
{"group":"apps","name":"insights-operator","namespace":"openshift-insights","resource":"deployments"}
{"group":"","name":"pull-secret","namespace":"openshift-config","resource":"secrets"}
{"group":"","name":"support","namespace":"openshift-config","resource":"secrets"}
{"group":"","name":"gather","namespace":"openshift-insights","resource":"serviceaccounts"}
{"group":"","name":"operator","namespace":"openshift-insights","resource":"serviceaccounts"}
{"group":"","name":"metrics","namespace":"openshift-insights","resource":"services"}
{"group":"","name":"service-ca-bundle","namespace":"openshift-insights","resource":"configmaps"}And: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_insights-operator/666/pull-ci-openshift-insights-operator-master-e2e/1562059761355067392/artifacts/e2e/gather-must-gather/artifacts/must-gather.tar | tar -tvz | grep insightsoperator
-rw------- 1008750000/root 19757 2022-08-23 07:53 registry-build04-ci-openshift-org-ci-op-rr1gwtx2-stable-sha256-7ba86eeb5e5e97946caaff9c94f1e1350c91b8773cf49bbfc9d6a36ab4f47280/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/insightsoperators.operator.openshift.io.yaml
-rw------- 1008750000/root 5242 2022-08-23 07:53 registry-build04-ci-openshift-org-ci-op-rr1gwtx2-stable-sha256-7ba86eeb5e5e97946caaff9c94f1e1350c91b8773cf49bbfc9d6a36ab4f47280/cluster-scoped-resources/apiserver.openshift.io/apirequestcounts/insightsoperators.v1.operator.openshift.io.yaml |
wking
reviewed
Aug 23, 2022
| apiVersion: operator.openshift.io/v1 | ||
| kind: InsightsOperator | ||
| metadata: | ||
| name: cluster |
There was a problem hiding this comment.
You need to annotate this with include.release.openshift.io/... for the cluster profiles it should belong to. See your other manifests for examples. As it stands now:
$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_insights-operator/666/pull-ci-openshift-insights-operator-master-e2e/1562059761355067392/artifacts/e2e/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-5bff5b8bd6-2d6n7_cluster-version-operator.log | grep kind=InsightsOperator
I0823 13:42:20.564370 1 payload.go:210] excluding 0000_50_insights-operator_09-operator-cr.yaml group=operator.openshift.io kind=InsightsOperator namespace= name=cluster: no annotations
I0823 13:42:21.332159 1 payload.go:210] excluding 0000_50_insights-operator_09-operator-cr.yaml group=operator.openshift.io kind=InsightsOperator namespace= name=cluster: no annotations
openshift-merge-robot
added
the
needs-rebase
tremes
force-pushed
the
operator-status
branch
from
c857f30 to
2347d3f
Compare
openshift-merge-robot
removed
the
needs-rebase
tremes
force-pushed
the
operator-status
branch
from
09a3e27 to
a1200cd
Compare
tremes
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
rluders
approved these changes
Aug 25, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rluders, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/test insights-operator-e2e-tests |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@tremes: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atus attribute
This add a new CR for the
insightsoperators.openshift.ioresource and implements itsgatherStatuspart.Categories
Sample Archive
No new data
Documentation
Unit Tests
extended a bit
pkg/controller/periodic/periodic_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/CCXDEV-8885
https://access.redhat.com/solutions/???