OCPBUGS-499: fix: order conditions by type to limit un-needed updates

[eggfoobar]

Signed-off-by: ehila [email protected]

Sorts the conditions array to avoid un-needed updates cluster operator status field

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

• pkg/controller/status/conditions_test.go

Privacy

N/A

Changelog

N/A

Breaking Changes

No

References

https://issues.redhat.com/browse/TRT-481

[eggfoobar]

/retest-required

[tremes]

Hi @eggfoobar thanks for your PR. I was looking at the related JIRA issue and it didn't tell me much. Can you elaborate please a little bit more why these conditions need to be sorted?
I think you will need a new OCPBUG for this

[eggfoobar]

Hey @tremes absolutely! The issue we saw was some extra activity updating the Status.Conditions of the operator that didn't seem to be needed. They all seem to be just updates that were re-ordering the conditions. This PR just sorts those conditions so later on in the code when the DeepEqual check is done to see if an update is needed, it should only trigger on changes not on re-orders

[eggfoobar]

Went ahead and created the bug for this as well, https://issues.redhat.com/browse/OCPBUGS-499

[tremes]

Thanks. Please change the title of the PR to OCPBUGS-499: fix: order conditions by type to limit un-needed updates and feel free to assignt the task to yourself :)

[openshift-ci-robot]

@eggfoobar: This pull request references [Jira Issue OCPBUGS-499](https://issues.redhat.com//browse/OCPBUGS-499), which is invalid:

• expected the bug to target the "4.12.0" version, but it targets "4.12" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Signed-off-by: ehila [email protected]

Sorts the conditions array to avoid un-needed updates cluster operator status field

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

• pkg/controller/status/conditions_test.go

Privacy

N/A

Changelog

N/A

Breaking Changes

No

References

https://issues.redhat.com/browse/TRT-481

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eggfoobar]

/jira refresh

[openshift-ci-robot]

@eggfoobar: This pull request references [Jira Issue OCPBUGS-499](https://issues.redhat.com//browse/OCPBUGS-499), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 11da6c7 and 8 for PR HEAD 12adc54 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 11da6c7 and 7 for PR HEAD 12adc54 in total

[openshift-ci]

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@eggfoobar: All pull requests linked via external trackers have merged:

• openshift/insights-operator#667

[Jira Issue OCPBUGS-499](https://issues.redhat.com//browse/OCPBUGS-499) has been moved to the MODIFIED state.

In response to this:

Signed-off-by: ehila [email protected]

Sorts the conditions array to avoid un-needed updates cluster operator status field

Categories

• Bugfix
• Enhancement
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

• pkg/controller/status/conditions_test.go

Privacy

N/A

Changelog

N/A

Breaking Changes

No

References

https://issues.redhat.com/browse/TRT-481

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.