OCPBUGS-13547: read featuregates from the shared API value #779
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
pkg/cmd/start/start.go
Outdated
| } | ||
| configInformers := configv1informers.NewSharedInformerFactory(configClient, 10*time.Minute) | ||
|
|
||
| desiredVersion := config.OperatorReleaseVersion |
There was a problem hiding this comment.
this needs to be teh version that we're going to write into the clusteroperator.
The gather command needs to know the version too.
pkg/cmd/start/start.go
Outdated
| } | ||
| configInformers := configv1informers.NewSharedInformerFactory(configClient, 10*time.Minute) | ||
|
|
||
| desiredVersion := os.Getenv("RELEASE_VERSION") |
There was a problem hiding this comment.
What launches the gather job? Having this match is important to get consistent feature gate behavior.
There was a problem hiding this comment.
This can be launched "manually" by the user (kubeadmin). Basically as an one-off operation - see https://docs.openshift.com/container-platform/4.12/support/remote_health_monitoring/remote-health-reporting-from-restricted-network.html. I think this is very edge case and I plan to remove it once the on-demand gathering is GA.
|
I think this is updated enough to be functional /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
| @@ -82,24 +84,45 @@ func (s *Operator) Run(ctx context.Context, controller *controllercmd.Controller | |||
| return err | |||
| } | |||
|
|
|||
| desiredVersion := os.Getenv("RELEASE_VERSION") | |||
| missingVersion := "0.0.1-snapshot" | |||
There was a problem hiding this comment.
This corresponds to https://github.com/openshift/insights-operator/blob/master/manifests/07-cluster-operator.yaml#L15, right? And it's updated by the CVO, right?
|
/retest |
1 similar comment
|
/retest |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
deads2k
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@deads2k: This pull request references Jira Issue OCPBUGS-13547, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
finishing off the external cloud provider featuregate shift. |
| // ensure the insight snapshot directory exists | ||
| if _, err = os.Stat(s.StoragePath); err != nil && os.IsNotExist(err) { | ||
| if err = os.MkdirAll(s.StoragePath, 0777); err != nil { | ||
| return fmt.Errorf("can't create --path: %v", err) | ||
| } | ||
| } | ||
| tpEnabled, err := isTechPreviewEnabled(ctx, configClient) |
There was a problem hiding this comment.
Can you please also remove the function isTechPreviewEnabled definition?
|
We will need to update https://docs.openshift.com/container-platform/4.12/support/remote_health_monitoring/remote-health-reporting-from-restricted-network.html#insights-operator-one-time-gather_remote-health-reporting-from-restricted-network so that the job defines |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
deads2k
force-pushed
the
render-fe
branch
2 times, most recently
from
74b4bcb to
3fc2172
Compare
|
@deads2k I think we need to update the permissions for the operator role, because I wasn't able to get a cluster (from your PR): |
|
/lgtm |
|
/override ci/prow/e2e-agnostic-upgrade |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@deads2k: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged:
The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…#779) * update library-go to get new featuregate reading method * read featuregates from the shared API value * default the job to match latest featuregates
This brings featuregate access up to the 4.14 standard.
/hold
I need to locate the version