OCPBUGS-16017: update DataGather CR status in case of job failure

[tremes]

This is only for TechPreview and it updates the DataGather custom resource status in case of failure. The datagather_conditions.go file has been renamed to datagather_status.go and some functions were moved there (to be able to reuse them easily).

Steps to verify:

1. Get TechPreview cluster
2. Switch to openshift-insights namespace
3. Wait for some periodic-gathering to happen and delete the Pod when it's running
4. Check the corresponding DataGather custom resource with the same name

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• no new data

Documentation

Unit Tests

• pkg/controller/status/datagather_status_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-16017
https://access.redhat.com/solutions/???

[openshift-ci-robot]

@tremes: This pull request references Jira Issue OCPBUGS-16017, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is only for TechPreview and it updates the DataGather custom resource status in case of failure. The datagather_conditions.go file has been renamed to datagather_status.go and some functions were moved there (to be able to reuse them easily).

Steps to verify:

1. Get TechPreview cluster
2. Switch to openshift-insights namespace
3. Wait for some periodic-gathering to happen and delete the Pod when it's running
4. Check the corresponding DataGather custom resource with the same name

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• no new data

Documentation

Unit Tests

• pkg/controller/status/datagather_status_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-16017
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tremes]

/retest

[ncaak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncaak]

/retest

[openshift-ci]

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tremes]

bugs should not require the qe-approved label. We need to fix it.
/label qe-approved

[openshift-ci-robot]

@tremes: Jira Issue OCPBUGS-16017: All pull requests linked via external trackers have merged:

• openshift/insights-operator#809

Jira Issue OCPBUGS-16017 has been moved to the MODIFIED state.

In response to this:

This is only for TechPreview and it updates the DataGather custom resource status in case of failure. The datagather_conditions.go file has been renamed to datagather_status.go and some functions were moved there (to be able to reuse them easily).

Steps to verify:

1. Get TechPreview cluster
2. Switch to openshift-insights namespace
3. Wait for some periodic-gathering to happen and delete the Pod when it's running
4. Check the corresponding DataGather custom resource with the same name

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

• no new data

Documentation

Unit Tests

• pkg/controller/status/datagather_status_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-16017
https://access.redhat.com/solutions/???

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.