add unit test for the InsightsDataGather Observer

[tremes]

Adding a basic unit test

Categories

• Bugfix
• Data Enhancement
• Feature
• Backporting
• Others (CI, Infrastructure, Documentation)

Sample Archive

no new data

Documentation

no docs required

Unit Tests

• pkg/config/configobserver/insightsdatagather_observer_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/???
https://access.redhat.com/solutions/???

[ncaak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak,tremes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tremes]

This is simple unit test so overriding some longer tests.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade

[JoaoFula]

/label qe-approved

[openshift-ci]

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-agnostic-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

This is simple unit test so overriding some longer tests.
/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e81d991 and 2 for PR HEAD 2a9532a in total

[tremes]

I broke our testsuite and we need to fix it. Overriding the rest for this one.
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/insights-operator-e2e-tests

[openshift-ci]

@tremes: Overrode contexts on behalf of tremes: ci/prow/e2e-gcp-ovn-techpreview, ci/prow/insights-operator-e2e-tests

In response to this:

I broke our testsuite and we need to fix it. Overriding the rest for this one.
/override ci/prow/e2e-gcp-ovn-techpreview
/override ci/prow/insights-operator-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.