Fix reporting duration error and add tests #84
Conversation
openshift-ci-robot
added
the
size/L
|
@martinkunc where is the BZ related to this? Is it just a test for 1753755? |
|
|
||
| } | ||
|
|
||
| var ( |
| actionName = getAction.GetName() | ||
| } | ||
|
|
||
| //log.Printf("namespace %s resource: %s verb %s Name %s", action.GetNamespace(), action.GetResource(), action.GetVerb(), actionName) |
There was a problem hiding this comment.
remove or uncomment
| errS = err.Error() | ||
| } | ||
| if expErrS != errS { | ||
| t.Fatalf("The test expected error doesn't fit actual error.\nExpected: %s Actual: %s", tt.expErr, err) |
There was a problem hiding this comment.
match is a better word then fit.
| ) | ||
|
|
||
| func TestChangeSupportConfig(t *testing.T) { | ||
| var cases = []struct { |
There was a problem hiding this comment.
I would rather create 2 tests, each test with only one purpose. It's more clear to read and understand. But up to you.
openshift-ci-robot
added
size/XXL
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandrevicenzi, martinkunc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
The retrieve config was doing checks for interval, but the actual error, but it declared new err variable, which was shadowing the original err.
That means any set inside of the block, when the block is left was discarded and err returned to original value from outer scope.
In case of too short interval (under 1 m) the outer 'err' was nil, even thought inner scope set it to "too short" it was discarded and function returned err = nil.