Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCXDEV-11387: feat(gather): gathering kubelet journal logs #863

Merged
merged 4 commits into from
Dec 3, 2023
Merged

CCXDEV-11387: feat(gather): gathering kubelet journal logs #863

merged 4 commits into from
Dec 3, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 10, 2023

This PR extends the node_logs gathering to filter extra messages from cluster kubelet logs.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/node/logs/ip-10-0-135-228.us-east-2.compute.internal.log 🆙

Documentation

  • docs/gathered-data.md 🆙

Unit Tests

Tests already exist.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/CCXDEV-11387

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 10, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 10, 2023 •
edited by openshift-ci bot
Loading

@rluders: This pull request references CCXDEV-11387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This PR extends the node_logs gathering to filter extra messages from cluster kubelet logs.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/node/logs/ip-10-0-135-228.us-east-2.compute.internal.log 🆙

Documentation

  • docs/gathered-data.md 🆙

Unit Tests

Tests already exist.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/CCXDEV-11387

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@rluders rluders marked this pull request as ready for review November 13, 2023 09:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@openshift-ci openshift-ci bot requested review from ncaak and rhrmo November 13, 2023 09:43
@rluders
Copy link
Contributor Author

rluders commented Nov 13, 2023

I need to check why the unit test is failing.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@rluders
Copy link
Contributor Author

rluders commented Nov 13, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@rluders rluders requested a review from tremes November 14, 2023 09:10
@rluders
Copy link
Contributor Author

rluders commented Nov 20, 2023

/retest

ncaak
ncaak approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 29, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot
Loading

@rluders: This pull request references CCXDEV-11387 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This PR extends the node_logs gathering to filter extra messages from cluster kubelet logs.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/node/logs/ip-10-0-135-228.us-east-2.compute.internal.log 🆙

Documentation

  • docs/gathered-data.md 🆙

Unit Tests

Tests already exist.

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

Yes/No

References

https://issues.redhat.com/browse/CCXDEV-11387

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f440fa0 and 2 for PR HEAD 7f056b8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4d4542e and 1 for PR HEAD 7f056b8 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9b91ed4 and 0 for PR HEAD 7f056b8 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 7f056b8 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2023
@tremes
Copy link
Contributor

tremes commented Dec 2, 2023

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a878ded into openshift:master Dec 3, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.15.0-202312040732.p0.ga878ded.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
@JoaoFula
CCXDEV-11387: feat(gather): gathering kubelet journal logs (openshift…
d51728a 
…#863)

* feat(gather): gathering kubelet journal logs

* docs: update node_logs sample data

* fix: node_logs regex needs double-quote

* fix: limit node by role and better error log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@rhrmo rhrmo Awaiting requested review from rhrmo

@tremes tremes Awaiting requested review from tremes

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rluders @openshift-ci-robot @JoaoFula @tremes @openshift-bot @ncaak