Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33082: Add new use cases for networking obfuscation #947

Merged
merged 2 commits into from
Jun 5, 2024
Merged

OCPBUGS-33082: Add new use cases for networking obfuscation #947

merged 2 commits into from
Jun 5, 2024

Conversation

ncaak
Copy link
Contributor

@ncaak ncaak commented Jun 4, 2024

This PR implements a new fix for previous PR #936

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

Yes

References

https://issues.redhat.com/browse/OCPBUGS-33082

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 4, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2024
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-33082, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new fix for previous PR #936

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

Yes

References

https://issues.redhat.com/browse/OCPBUGS-33082

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ncaak
Copy link
Contributor Author

ncaak commented Jun 4, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 4, 2024
@openshift-ci-robot
Copy link
Contributor

@ncaak: This pull request references Jira Issue OCPBUGS-33082, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 4, 2024
@openshift-ci openshift-ci bot requested a review from JoaoFula June 4, 2024 10:35
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@ncaak ncaak marked this pull request as ready for review June 4, 2024 10:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2024
@openshift-ci openshift-ci bot requested review from rhrmo and tremes June 4, 2024 10:36
@ncaak
Copy link
Contributor Author

ncaak commented Jun 4, 2024

/retest

@JoaoFula
Copy link
Contributor

JoaoFula commented Jun 5, 2024

techpreview tests are passing. Hiccup is on cluster de-provisioning. Feel free to override the tests if necessary.

tremes
tremes reviewed Jun 5, 2024
View reviewed changes
pkg/anonymization/anonymizer.go
kubeClient, err := kubernetes.NewForConfig(protoKubeConfig)
if err != nil {
return nil, err
}
sensitiveVals[extractDomain(protoKubeConfig.Host)] = ClusterHostPlaceholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea using the kubeconfig data! 👍

@tremes
Copy link
Contributor

tremes commented Jun 5, 2024

I didn't try that, but
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@ncaak
Copy link
Contributor Author

ncaak commented Jun 5, 2024

/test e2e

@ncaak
Copy link
Contributor Author

ncaak commented Jun 5, 2024

/test e2e-gcp-ovn-techpreview

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 5, 2024

@ncaak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c712388 into openshift:master Jun 5, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@ncaak: Jira Issue OCPBUGS-33082: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33082 has been moved to the MODIFIED state.

In response to this:

This PR implements a new fix for previous PR #936

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • path/to/sample_data.json

Documentation

  • path/to/documentation.md

Unit Tests

  • path/to/file_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

No

Breaking Changes

Yes

References

https://issues.redhat.com/browse/OCPBUGS-33082

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.17.0-202406052200.p0.gc712388.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

@rhrmo rhrmo Awaiting requested review from rhrmo

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ncaak @openshift-ci-robot @JoaoFula @tremes @openshift-bot