OCPBUGS-53249: skip UDP LoadBalancer on external

[mtulio]

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

The intention of this PR is to skip the tests below in the platform type External as it is not configured properly (when trying to use UDP service LB on AWS, for instance), and those are permanent failing on that platform.

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s] 

OpenShift CI exercises platform type External on AWS and vSphere providers, both requires additional configuration to CCM created correctly the service LoadBalancer using UDP protocol, such requirements is not implemented by upstream k8stest. Those tests are also skipped by AWS and vSphere.

Which issue(s) this PR fixes:

Fixes # OCPBUGS-53249

Special notes for your reviewer:

The support to platform type External in the test framework was added on openshift/origin#29623 to satisfy and test changes here using the job e2e-external-aws-ccm.

Those tests are not valid on platform type External when using CCM for the same reason it isn't in the integrated providers - requires additional setup, or service does not support it.

There is only one scenario I can see that those upstream tests could be exercised: cluster installed with platform type External without CCM, it will behave like platform None. Although we don't have test scenarios enabled checking advanced platform external configurations, such as checking if the CCM is enabled in the Infrastructure object.

Does this PR introduce a user-facing change?

NONE.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

This PR forces to skip the service LoadBalancer tests on OCP clusters installed on platform type External.

OpenShift CI exercises platform type External on AWS and vSphere providers, both requires additional configuration to CCM created correctly the service LoadBalancer using UDP protocol, such requirements is not implemented by upstream k8stest. Those tests are also skipped by AWS and vSphere.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mtulio: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 6d0a9db|UPSTREAM: : OCPBUGS-53249: skip UDP LoadBalancer on external: does not specify an upstream backport in the commit message
• ed4eace|UPSTREAM: : OCPBUGS-53249: skip UDP LoadBalancer on external: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[mtulio]

/payload-job periodic-ci-openshift-release-master-nightly-4.19-opct-external-aws-ccm

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-opct-external-aws-ccm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b01a04e0-042d-11f0-90cb-015f6b2ba05e-0

[mtulio]

/payload-job pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm

[openshift-ci]

@mtulio: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[mtulio]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-opct-external-aws-ccm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b01a04e0-042d-11f0-90cb-015f6b2ba05e-0

Inspecting the running job, looks like this test does not have the test updated in the kube binary:

sh-5.1$ oc -n opct logs sonobuoy-20-openshift-conformance-validated-job-ef73d695b97c46ba -c tests | grep 'hould be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on'

started: 0/104/768 "[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]"

started: 0/411/768 "[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]"
    [sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes (Spec Runtime: 14m59.796s)

failed: (15m0s) 2025-03-18T21:40:53 "[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]"
    [sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes (Spec Runtime: 14m59.675s)

failed: (15m0s) 2025-03-18T21:44:30 "[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]"

I will trigger a job which is included in payload

/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/97d54ae0-0453-11f0-9e49-8672f64bf879-0

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a8ced7d0-0453-11f0-8a5f-199fd77e3095-0

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

The intention of this PR is to skip the tests below in the platform type External as it is not configured properly (when trying to use UDP service LB on AWS, for instance), and those are permanent failing on that platform.

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s] 

OpenShift CI exercises platform type External on AWS and vSphere providers, both requires additional configuration to CCM created correctly the service LoadBalancer using UDP protocol, such requirements is not implemented by upstream k8stest. Those tests are also skipped by AWS and vSphere.

Which issue(s) this PR fixes:

Fixes # OCPBUGS-53249

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

Summary of tests so far:

• A/ The tests are hidden in the payload jobs from AWS 1 2, which is expected as not breaking regular jobs, and keeps hiding in past jobs, such as this
• B/ The tests are still failing in the payload job of original issue. job (direct log)

considering all other platforms are skipping this test, I wonder if:

• Do I need to add a presbumit to this repo to a platform type external workflow?
• Is there additional work to make this available in the openshift-tests? Is the presubmit enough to validate it?

Additionally, this bug is also blocking origin presubmits, see example of failures from a PR targeting a stable branch (4.18):

• ci/prow/e2e-external-aws openshift/origin@02878b3 link false /test e2e-external-aws
• ci/prow/e2e-external-vsphere-ccm openshift/origin@02878b3 link false /test e2e-external-vsphere-ccm
• ci/prow/e2e-external-aws-ccm openshift/origin@02878b3 link false /test e2e-external-aws-ccm

[mtulio]

Summary of tests so far:

Hey @bertinatto , would you mind taking a look at this results so far?

[mtulio]

I just opened a PR to create a presubmit here - openshift/release#63002
Let me check standard signals.
/test all

[mtulio]

/jira refresh

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-53249, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bertinatto]

considering all other platforms are skipping this test, I wonder if:

* Do I need to add a presbumit to this repo to a platform type external workflow?

If the periodic job isn't helping, adding a presubmit here makes sense. Probably an optional one (that you need to manually invoke with /test job-name).

* Is there additional work to make this available in the `openshift-tests`? Is the presubmit enough to validate it?

Skipping the tests here is usually enough, unless the job has a different config and is not pulling the external binary to run the tests. In that case, you need to vendor this code inside o/o.

[bertinatto]

/test ?

[openshift-ci-robot]

@mtulio: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 0256129|UPSTREAM: : make update: does not specify an upstream backport in the commit message
• ed4eace|UPSTREAM: : OCPBUGS-53249: skip UDP LoadBalancer on external: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[mtulio]

Can you rename the last commit to something like UPSTREAM: <drop>: make update?

/remove-label backports/unvalidated-commits /label backports/validated-commits

Hey @bertinatto , sure! Renamed! Would you mind taking a look, please?

[bertinatto]

/lgtm

[bertinatto]

/remove-label backports/unvalidated-commits
/label backports/validated-commits

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, mtulio, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

/lgtm

Hey @bertinatto do you think we can backport this to 4.18? I see the statement to other platforms in ocp 4.18 branch[1] as it was added on kube 1.31.
[1] https://github.com/openshift/kubernetes/blob/release-4.18/openshift-hack/e2e/annotate/rules.go#L225-L230

[mtulio]

/lgtm

Hey @bertinatto do you think we can backport this to 4.18? I see the statement to other platforms in ocp 4.18 branch[1] as it was added on kube 1.31. [1] https://github.com/openshift/kubernetes/blob/release-4.18/openshift-hack/e2e/annotate/rules.go#L225-L230

The PR to backport the origin change is triggered here openshift/origin#29666

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e15f4f8 and 2 for PR HEAD 0256129 in total

[mtulio]

/retest-required

[openshift-ci]

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	0256129	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-agnostic-ovn-cmd	0256129	link	false	/test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@mtulio: Jira Issue OCPBUGS-53249: All pull requests linked via external trackers have merged:

• openshift/kubernetes#2247
• openshift/release#63002
• openshift/origin#29623
• openshift/release#63367
• openshift/release#63446

Jira Issue OCPBUGS-53249 has been moved to the MODIFIED state.

In response to this:

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

The intention of this PR is to skip the tests below in the platform type External as it is not configured properly (when trying to use UDP service LB on AWS, for instance), and those are permanent failing on that platform.

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s]

[sig-network] LoadBalancers [Feature:LoadBalancer] should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on different nodes [Skipped:alibabacloud] [Skipped:aws] [Skipped:baremetal] [Skipped:ibmcloud] [Skipped:kubevirt] [Skipped:nutanix] [Skipped:openstack] [Skipped:ovirt] [Skipped:vsphere] [Suite:openshift/conformance/parallel] [Suite:k8s] 

OpenShift CI exercises platform type External on AWS and vSphere providers, both requires additional configuration to CCM created correctly the service LoadBalancer using UDP protocol, such requirements is not implemented by upstream k8stest. Those tests are also skipped by AWS and vSphere.

Which issue(s) this PR fixes:

Fixes # OCPBUGS-53249

Special notes for your reviewer:

The support to platform type External in the test framework was added on openshift/origin#29623 to satisfy and test changes here using the job e2e-external-aws-ccm.

Those tests are not valid on platform type External when using CCM for the same reason it isn't in the integrated providers - requires additional setup, or service does not support it.

There is only one scenario I can see that those upstream tests could be exercised: cluster installed with platform type External without CCM, it will behave like platform None. Although we don't have test scenarios enabled checking advanced platform external configurations, such as checking if the CCM is enabled in the Infrastructure object.

Does this PR introduce a user-facing change?

NONE.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.19.0-202504100822.p0.gc9e894a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.19.0-202504100822.p0.gc9e894a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.19.0-202504100822.p0.gc9e894a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.19.0-202504100822.p0.gc9e894a.assembly.stream.el9.
All builds following this will include this PR.