Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRT-2066: Use OTE generated labels for skips in test-kubernetes-e2e.sh #2255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smg247
Copy link
Member

@smg247 smg247 commented Mar 31, 2025

As part of the deprecation and removal of the annotation framework, we must allow test-kubernetes-e2e.sh to retain current functionality without relying on the annotations. In order to do this, we can rely on the OTE binary's list tests command to get the spec names and their labels. This is possible because the specs have been updated here to also include the reason why they are being skipped as a label, alongside adding the environmentSelector. These labels will then be stored in a map from the spec name to the labels in a generated file. This map will then be appended to the spec name for only the purpose of determining if a test should be skipped in the script.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 31, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2025
Copy link

openshift-ci bot commented Mar 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

openshift-ci bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smg247
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@smg247 smg247 changed the title WIP: PoC to use OTE generated labels for skips in test-kubernetes-e2e.sh Use OTE generated labels for skips in test-kubernetes-e2e.sh Apr 2, 2025
@smg247 smg247 marked this pull request as ready for review April 2, 2025 19:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and jerpeter1 April 2, 2025 19:32
@smg247
Copy link
Member Author

smg247 commented Apr 2, 2025

/hold for #2254 and #2256

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2025
@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@smg247 smg247 changed the title Use OTE generated labels for skips in test-kubernetes-e2e.sh TRT-2066: Use OTE generated labels for skips in test-kubernetes-e2e.sh Apr 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025

@smg247: This pull request references TRT-2066 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

As part of the deprecation and removal of the annotation framework, we must allow test-kubernetes-e2e.sh to retain current functionality without relying on the annotations. In order to do this, we can rely on the OTE binary's list tests command to get the spec names and their labels. This is possible because the specs have been updated here to also include the reason why they are being skipped as a label, alongside adding the environmentSelector. These labels will then be stored in a map from the spec name to the labels in a generated file. This map will then be appended to the spec name for only the purpose of determining if a test should be skipped in the script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@smg247
Copy link
Member Author

smg247 commented Apr 4, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2025
@smg247
Copy link
Member Author

smg247 commented Apr 4, 2025

/test verify

2 similar comments
@smg247
Copy link
Member Author

smg247 commented Apr 4, 2025

/test verify

@smg247
Copy link
Member Author

smg247 commented Apr 4, 2025

/test verify

@smg247
Copy link
Member Author

smg247 commented Apr 7, 2025

/retest-required

…ssitates generating labels that match specs, and appending them to the spec name for that purpose only.

comment
@openshift-ci-robot
Copy link

@smg247: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@smg247
Copy link
Member Author

smg247 commented Apr 8, 2025

/retest-required

1 similar comment
@smg247
Copy link
Member Author

smg247 commented Apr 10, 2025

/retest-required

Copy link

openshift-ci bot commented Apr 10, 2025

@smg247: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 93f3228 link false /test e2e-agnostic-ovn-cmd
ci/prow/k8s-e2e-aws-ovn-serial 93f3228 link false /test k8s-e2e-aws-ovn-serial
ci/prow/okd-scos-e2e-aws-ovn 93f3228 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-csi 93f3228 link false /test e2e-aws-csi
ci/prow/k8s-e2e-gcp-serial 93f3228 link true /test k8s-e2e-gcp-serial
ci/prow/k8s-e2e-gcp-ovn 93f3228 link true /test k8s-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants