-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-2066: Use OTE generated labels for skips in test-kubernetes-e2e.sh #2255
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smg247 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@smg247: This pull request references TRT-2066 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/hold cancel |
/test verify |
2 similar comments
/test verify |
/test verify |
/retest-required |
…ssitates generating labels that match specs, and appending them to the spec name for that purpose only. comment
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/retest-required |
1 similar comment
/retest-required |
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As part of the deprecation and removal of the annotation framework, we must allow
test-kubernetes-e2e.sh
to retain current functionality without relying on the annotations. In order to do this, we can rely on the OTE binary'slist tests
command to get the spec names and their labels. This is possible because the specs have been updated here to also include the reason why they are being skipped as a label, alongside adding theenvironmentSelector
. These labels will then be stored in a map from the spec name to the labels in a generated file. This map will then be appended to the spec name for only the purpose of determining if a test should be skipped in the script.