test rebase + test initialization #2313
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add device-plugin-test e2e log
Remove general available feature-gate CPUManager
…ularContainerImgChangeE2E Revert "Add e2e test for Regular Container image change"
The defaulting of TimeAdded randomly broke some of the tests:
TestList:
resttest.go:1393: expected:
[]runtime.Object{(*resource.DeviceTaintRule)(0xc000b83080), (*resource.DeviceTaintRule)(0xc000b831e0)},
got:
[]runtime.Object{(*resource.DeviceTaintRule)(0xc0003db608), (*resource.DeviceTaintRule)(0xc0003db750)}
...
TestCreate:
resttest.go:346: unexpected obj: &resource.DeviceTaintRule{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"foo2", GenerateName:"", Namespace:"", SelfLink:"", UID:"18d3084d-7d11-4575-8730-4650b81cf1a7", ResourceVersion:"8", Generation:1, CreationTimestamp:time.Date(2025, time.March, 21, 8, 27, 23, 0, time.Local), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:resource.DeviceTaintRuleSpec{DeviceSelector:(*resource.DeviceTaintSelector)(nil), Taint:resource.DeviceTaint{Key:"example.com/taint", Value:"", Effect:"NoExecute", TimeAdded:time.Date(2025, time.March, 21, 8, 27, 23, 0, time.Local)}}}, expected &resource.DeviceTaintRule{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"foo2", GenerateName:"", Namespace:"", SelfLink:"", UID:"18d3084d-7d11-4575-8730-4650b81cf1a7", ResourceVersion:"8", Generation:1, CreationTimestamp:time.Date(2025, time.March, 21, 8, 27, 23, 0, time.Local), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Spec:resource.DeviceTaintRuleSpec{DeviceSelector:(*resource.DeviceTaintSelector)(nil), Taint:resource.DeviceTaint{Key:"example.com/taint", Value:"", Effect:"NoExecute", TimeAdded:time.Date(2025, time.March, 21, 8, 27, 24, 0, time.Local)}}}
Failure rate before: 3m40s: 1332 runs so far, 7 failures (0.53%)
It's not obvious from the test failure, but the difference is the
TimeAdded. Setting it beforehand to a value that can be encoded (i.e. truncated
to seconds) fixes the flake.
Failure rate after: 5m0s: 1825 runs so far, 0 failures
De-flake infeasible resize test
goos: linux goarch: amd64 pkg: k8s.io/client-go/tools/cache cpu: Intel(R) Xeon(R) CPU @ 2.60GHz BenchmarkLister_Match_1k_100 BenchmarkLister_Match_1k_100-48 41910 28255 ns/op 16384 B/op 1 allocs/op BenchmarkLister_Match_10k_100 BenchmarkLister_Match_10k_100-48 3487 337728 ns/op 163848 B/op 1 allocs/op BenchmarkLister_Match_100k_100 BenchmarkLister_Match_100k_100-48 222 7040793 ns/op 1605659 B/op 1 allocs/op BenchmarkLister_Match_1M_100 BenchmarkLister_Match_1M_100-48 12 97962328 ns/op 16007172 B/op 1 allocs/op PASS ok k8s.io/client-go/tools/cache 10.480s
benchmarks inefficiency on listers linear search lookup
…t-flake DRA API: fix DeviceTaintRule REST storage test
…efs-tests Revert "Separate SeparateDiskTests from eviction"
Run in-place resize tests in default CI jobs
Includes v2beta2 HPA round-trip conversion, defaulting, and validation.
also debug inotify limits before/after setting
…erd-node-e2e CI jobs Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
…-kube-up kube-up.sh: set inotify limits
…n-for-kubelet-metrics-url Use established pattern for kubelet metrics url
The test that checks that a volume can be accessed from multiple nodes should create ReadWriteMany volume and not ReadWriteOnce.
Co-authored-by: Hemant Kumar <[email protected]> Signed-off-by: carlory <[email protected]>
Co-authored-by: Allen Ray <[email protected]>
…1 as deprecated." This reverts commit 24bf6d5.
…ates various priority Pods preempt expectedly with the async preemption: replace finalizers with preStop hook and TerminationGracePeriodSeconds
…espaceDeletion test serial
SELinux tests require testContext to be initialized before ginkgo discovers their closures (i.e. before kubeTestsExtension.AddSuite() is called). Split the testContext initialization in two parts: initializeCommonTestFramework() files the fields that are either static or can be discovered easily and are needed to generate the tests by ginkgo. updateTestFrameworkForTests() files the rest, mostly from the cloud provider env. var. and adds fields necessary to actually run the tests.
…rkForTests It logs, and the logs go right to stdout, where openshift-tests reads json from "k8s-tests-ext list" and "info".
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
backports/unvalidated-commits
|
/payload-job openshift-kubernetes-2261-nightly-4.20-e2e-metal-ipi-ovn-bm |
|
@jsafrane: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm |
|
@jsafrane: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b8cc69d0-3a0f-11f0-9949-844625e97f35-0 |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test #2309 with the 1.33 rebase