Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-1630: fix - api token check for AzureOpenAI provider #689

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Apr 3, 2025

Description

fix the LLM token check logic for the provider AzureOpenAI for the following keys:

  • client_id
  • tenant_id
  • client_secret

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025

@raptorsun: This pull request references OLS-1630 which is a valid jira issue.

In response to this:

Description

fix the LLM token check logic for the provider AzureOpenAI for the following keys:

  • client_id
  • tenant_id
  • client_secret

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 3, 2025

@raptorsun: This pull request references OLS-1630 which is a valid jira issue.

In response to this:

Description

fix the LLM token check logic for the provider AzureOpenAI for the following keys:

  • client_id
  • tenant_id
  • client_secret

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh April 3, 2025 10:15
@JoaoFula
Copy link
Contributor

JoaoFula commented Apr 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@raptorsun
Copy link
Contributor Author

/approve

@raptorsun
Copy link
Contributor Author

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

Copy link

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raptorsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
Copy link

openshift-ci bot commented Apr 4, 2025

@raptorsun: Overrode contexts on behalf of raptorsun: Red Hat Konflux / ols-enterprise-contract / lightspeed-operator

In response to this:

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Apr 4, 2025

@raptorsun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 45ad86a into openshift:main Apr 4, 2025
11 of 12 checks passed
@raptorsun raptorsun deleted the fix-azure-token branch April 4, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants