Add chunking for documentation in HTML form #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
/cc |
max-svistunov
force-pushed
the
ols-1498-chunking-html
branch
from
6b0f7dc to
b69bdee
Compare
max-svistunov
force-pushed
the
ols-1498-chunking-html
branch
from
a4448d3 to
ddceb5e
Compare
Add HTML tag-to-text ratio detection Improve section hierarchy handling with; better fallback handling Better parent context handling in section tree chunking Fix parsing when soup.body is None Fix code blcok handling
max-svistunov
force-pushed
the
ols-1498-chunking-html
branch
from
ddceb5e to
b2ab598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@syedriko Could you PTAL? At this point I'm mostly interested whether you agree with the approach, as I'm still finishing work on the prepend_parent_section_text and keep_siblings_together options. Thank you.